Trendyol/baklava

[BUG]: Empty bl-select causes floating-ui to throw an error

ogunb opened this issue ยท 2 comments

Issue description

Let's say you want to fetch options as user inputs search.

  1. Start with an empty bl-select.
  2. Click on bl-select.

The click action is going to log the error below and break popover functionality.
Uncaught TypeError: Cannot read properties of null (reading 'assignedSlot')

Reproduction: https://codepen.io/ogunb/pen/yLrqrZg

This is also preventing developers to slot things other than bl-select-option into the select component, such as an error message with a custom icon. Even though this may not something we want to support, it feels like a breaking change. Maybe we should go with a css solution instead.

#794
#803

Media & Screenshots

No response

Baklava Version

3.0.0-beta.5

Operating system

No response

Priority this issue should have

Medium (should be fixed soon)

Please review the checkboxes that are applicable.

  • This issue is directly related to React

๐ŸŽ‰ This issue has been resolved in version 3.0.0-beta.11 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

๐ŸŽ‰ This issue has been resolved in version 3.1.0 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€