TritonDataCenter/node-triton

Triton SSH w/ Git Bash - ssh version change breaks

Opened this issue · 3 comments

qdzlug commented

Hi,

Under Git Bash (installed using the Git tooling), using triton ssh works as expected under:

$ ssh -V
OpenSSH_7.3p1, OpenSSL 1.0.2j  26 Sep 2016

However, if you are using:

$ ssh -V
OpenSSH_7.6p1, OpenSSL 1.0.2m  2 Nov 2017

You receive this error:

$ triton ssh 3a1f3346
command-line line 0: garbage at end of line; "Cobine\\AppData\\Roaming\\Joyent\\Triton\\tmp\\nullSshControlPath".

Looks to be something perhaps with a default change with the ssh client?

Jay

ccobine commented

Robby restested this using OpenSSH for Windows version 7. This is still an issue but would be good to correct for our customers.

blackwood821 commented

One of our users just ran into this as well. They are the only user with a space in their Windows username. Seems like this line should quote the path:

https://github.com/TritonDataCenter/node-triton/blob/master/lib/do_instance/do_ssh.js#L316

Will be testing this shortly and if a change to that line fixes the issue I'll create a PR.

blackwood821 commented

I created a pull request for a change that addresses this issue: #334