Trust-Machines/multisafe

In UI there it is not possible to revoke a pending, unauthorized transaction

Opened this issue · 3 comments

wbnns commented

On the Transactions page, when loaded by for review an owner that was not the transaction originator, there is no REVOKE button. So hypothetically speaking, let's say one of the owner accounts was compromised and an unauthorized transaction was made by it. There is no revoke button for the other owners.

image

We have a simple confirmation based transaction finalization method which is quite easy to use and understand. Revoking a transaction created by another owner is more like a voting based model and in practice i don't think it would be necessary because; if wallet of the one owner compromised then other owners can kick that owner out.

The compromised wallet can spam the multisig wallet creating transactions until it gets removed from owner list and one undesired result can be to see those transactions on the UI forever. And it may feel like there are some unfinished tasks on the multisig wallet. To avoid that we can add a "hide" button to UI to allow the user to hide transactions they don't want to see. Does it makes sense?

wbnns commented

@talhasch

Ok, I see. What do you recommend procedure be for another owner if they do not want to Confirm a transaction? Another example am thinking here is perhaps if one Owner erroneously inputs data for an outgoing transaction (incorrect address, incorrect amount that is too much). In these cases, how should the other owners revoke the transaction so it still doesn't go out?

@wbnns

A transactions stays as unconfirmed forever without executing anything until it gets enough confirmation from all owners. So, if an owner doesn't want to confirm the tx they don't need to do anything. But if the tx gets enough confirmation from other owners it gets executed anyway.

For txs that contains erroneously input, one quick recommendation can be all owners to revoke their confirmations from it so it appears as 0 confirmation on the UI so you can distinguish it was a mistakes one.