Could it be better to delegate icon work to CSS ?

Question

Could it be better to delegate icon work to CSS ?

noomz opened this issue 12 years ago · 2 comments

I think it should be better if there's an option to custom whether to style icon using JS (like $(element).css() ) or should it be done by CSS. It also good for designer(stylesheet composer) too.

Answer 1 · 2012-10-10T15:04:23.000Z

Currently the li elements has unique IDs, so you can use CSS to modify the style of the icon

Answer 2 · 2012-10-10T18:10:38.000Z

As vrnagy pointed out, this should be easy to override inside the CSS.

To do this would require a significant change to how new browsers are defined, as it would require editing jReject config as well as the CSS file. Currently is can be done in just the config, which I think is more usable. Though if you have a better solution, let me know.