Fix: some of the dictionary entries are malformed, only having first character's pinyin
Closed this issue ยท 1 comments
dengel29 commented
OS ๐
Mac
Node Version ๐ฆ
v19.9.0
Npm or Yarn Version ๐ฆ
pnpm 8.10.5
Severity / Criticality of the bug(s) ๐
High
What happened โ
I noticed this bug when calling getByTraditional, and reading the pinyin output. When getting the pinyin output, only the first character in a multi-character phrase will have its pinyin returned. This does not appear to be an issue with parsing the response, but with the dictionary itself. Here is an example entry from cedict.json
{
"traditional":"ๅๆ",
"simplified":"ๅๆ",
"pinyin":"bang4",
"english":["in the evening","when night falls","towards evening","at night fall","at dusk"]
}There are many such entries.
Relevant log output ๐
No response
Steps to reproduce the bug โฟ
No response
Contact Details ๐ซ
Code of Conduct
- I agree to follow this project's Code of Conduct
Tykok commented
Sorry, I didn't really take the time to correct this error. Thanks for this ticket ๐๐ฝ