[quality] Align `DisposableCollection` with Theia?
Opened this issue · 1 comments
kittaakos commented
The DisposableCollection
is cool and convenient to use, however, what we have fixed in Theia never got back to here. Time to update or publish the DisposableCollection
to npmjs and we do not have to copy-paste the code over and over.
See the diffs:
vscode-ws-jsonrpc/src/disposable.ts
Lines 12 to 33 in b9dbfda
akosyakov commented
I think we should get rid of this package and merge it in Theia, something like @theia/jsonrpc
. Also see eclipse-theia/theia#1783