Download button

[zuphilip]

(Splitted from #60)

Current Behaviour

After uploading a local file and transform it, the download button does nothing.

After choosing an url of a file and transform it, the download button will simply provide a link to that url, which is the input file.

Goal

The goal should be to download the output file. I guess that the button is currently more like a placeholder and the logic behind it is still missing.

Code

I only have found this code for the button:

ocr-fileformat/web/ocr-fileformat.js

Lines 86 to 96 in 5ec0dd4

	api.request(tabName, params, formData, function(err, data) {
	pane.find("button .spinning").addClass('hidden');
	if (err)
	return $.notify(err, 'error');
	if (url) {
	pane.find(".result a.download").attr('href', url);
	}
	pane.find(".result pre code").html(escapeHTML(data));
	pane.find(".result").removeClass('hidden');
	Prism.highlightAll()
	});

.

[stweil]

Pull request #70 partially implemented the desired functionality. The following use case still does not work for me:

• Go to https://digi.bib.uni-mannheim.de/ocr-fileformat/
• Enter URL https://digi.bib.uni-mannheim.de/~stweil/ocr-praxis/0001-tesseract.hocr
• Transform from hocr to alto2.0
• Press 'Download' button

Expected behavior: download of result (ALTO XML)
Observed behavior: download of input (hOCR)

[zuphilip]

Yes, that is the else case in

ocr-fileformat/web/ocr-fileformat.js

Lines 103 to 105 in b85360e

	} else {
	pane.find(".result a.download").attr('href', input.val());
	}

. I agree that we don't need this and should just always do what is in the if case.

[kba]

Yup, and change the basename replacement. I'll send a PR.

[kba]

Also needs to make use of Blob/createObjectURL/revokeObjectURL since src attribute will become too large quickly.

[zuphilip]

It seems that #73 fixed this.

However, the behavior on digi is still different. @stweil Can you check that we have the latest version running?

[stweil]

We do now. Before that, a two years old version was running.