UBC-MDS/global_warming_effects_on_ice_thickness

Milestone 2 General Feedback

Closed this issue · 1 comments

Hello Global Warming Effects on Ice thickness Group!

Overall I enjoyed reading your report, and I was able to run your code without problems!
-code well formatted and concise, commented as needed, some checks/tests in separate code files
-good use of issues for project tracking and discussion. I like the added labels too

  • rationale good, and clear!

Suggestions for the Report:

  1. names and date missing in report
  2. first graph is blurry, make it smaller, save a larger file, or save diff format like pdf/svg
    a different plot instead of a bar plot might be good, I am wondering if certain stations have different ice thicknesses and how that relates within each year. Or adding error bars at a minimum to the bar graph.
  3. I'm also wondering if it would be best to compare the individual stations in 1984 to the station in 1994, because the distributions in your eda shows very different ice thickness distributions for each station. Also the magnitude of change across a year is also different for each station. I do also like how you are moving to comparing individual months instead of just values for a whole year.
  4. could add a conclusion/result to summary in report
  5. minor writing errors, end of report should say 'in the figure above' at the very end.
  6. The years you are highlighting and comparing change in the report. 1984 - 2002, then 1984 v 1996, then 1984 v 1994. The last two I would expect to be the same, by changing the ranges I am not sure how your narrative flows, since you are telling me about one comparison, then another with a stat test, and I can't compare them easily since they are two totally different comparisons even though the trends are likely the same.

Tiff brought up that it might be useful to consider using a non-parametric test, like a permutation, if you are using samples with different distributions. But it will come down to how you approach answering your question.