UDAAN-LEAP/leap-pe-tool

New feature to save user completed pages

Closed this issue · 13 comments

NishantWankhade commented

We have tried implementing the corrected, verified and mark for review by saving them in a text files. However it was increasing the size of text files.
Now we have to implement same feature however now we should add the to qsettings object for each different book of that user.

NishantWankhade commented

Expected Outcome of tasks :-

  • Add a checkbox similar to "Mark for review" in which one will be visible for corrector and another will be visible only for verifier
  • Save the checked pages in a qsettings object, Which will have hierarchy as below
    IIT-B organization Setting object
    |- Corrected Pages
    | |- Book Name 1
    | |- Page names
    |- Verified Pages
    |- Book Name 1
    |- Page names
  • After opening the Project corresponding settings should be read and the status of the opened file should be reflected on checkbox
  • After changing the pages that status of that page should also reflect on checkbox
NishantWankhade commented

Writing and reading of settings assigned to @AayushGupta69
Handling status of the current page assigned to @saanvibehele

NishantWankhade commented

Previous task done :- f9b3a58
@AayushGupta69

  • Bug in checkbox i.e. that status checkbox should be disabled after closing the project ... Rather it would be better to set its visibility to false if no project is open.
NishantWankhade commented

Previous task done :- eb61550
@saanvibehele

  • Bug in verifier checkbox i.e. verifier is not able to check the verifier checkbox.
saanvibehele commented

bug fixed on commit: e8adbdd
task completed

AayushGupta69 commented

Bug fixed on commit 3e24ca7

NishantWankhade commented

Assigned to @AayushGupta69 ---
How to get the bug

  • Open any project
  • Mark some pages as corrected
  • Click on File -> Exit button
  • Reopen the tool and same project
  • You will see that it status is cleared
NishantWankhade commented

Assigned to @saanvibehele ---
For corrector the checkbox must be enabled only when the current page opened is from folder "CorrectorOutput"
Similarly for verifier that should be the case.
And for rest of the folders from treeview it should be invisible.

AayushGupta69 commented

Update:

  • Refactored some code at commit bcbe026

  • Fixed the bug at the commit 7c0bb1e

There is still one bug left. When we open a project, the status of the checkbox does not update automatically even though the pages have been successfully read. We have to change the page from the treeView to update the checkbox and then it shows the status correctly.

NishantWankhade commented

Assigned to @AayushGupta69
Bug

  • Open a project
  • Click on the page which is already marked
  • Close the project
  • Reopen the project
  • You will notice that the current page was already marked however it was not showing the status just after opening the project

After opening the project it should reflect the current page status also.

NishantWankhade commented

Update:

  • Refactored some code at commit bcbe026
  • Fixed the bug at the commit 7c0bb1e

There is still one bug left. When we open a project, the status of the checkbox does not update automatically even though the pages have been successfully read. We have to change the page from the treeView to update the checkbox and then it shows the status correctly.

You should set the status of current page in function RecentPageInfo which is called at the end of OpenProject.

saanvibehele commented

Fixed it at commit number: 58c7a37
The bug didn't exist on the branch userCompletedPages.
It was introduced during merge, but it fixed now as it was originally in userCompletedPages.