C# SDK

Question

C# SDK

jchannon opened this issue 4 years ago · 12 comments

Hi,

Apologies that this is not python related but I've written a C# SDK if you are interested in taking ownership of it? It has most of the functionality and a sample app to demonstrate it's use. I saw you had R, Python & Javascript and wondered if you'd want a C# one too?

Here's the repo if you'd like it - https://github.com/jchannon/coronavirus-dashboard-api-net-sdk

Thanks!

Answer 1 · 2020-08-07T15:37:19.000Z

@jchannon Thank you for the offer, we are very grateful. We will be more than happy to take ownership and maintain the service.

Would you rather transfer the ownership to PHE via GitHub, or shall I create fork and redeploy the code to our repository? I would like to ensure that your contribution is recorded in the history of the project, and I will ensure that you are adequately acknowledged in any documentation.

Update:
I just shared your offer with a few members of our team, and you got a big "WOW" from every one of them... So, once again, thank you.

Answer 2 · 2020-08-07T16:12:22.000Z

I’ll transfer it via Github. Glad my contribution might help someone!

…

On Fri, 7 Aug 2020 at 16:37, Pouria Hadjibagheri ***@***.***> wrote: @jchannon <https://github.com/jchannon> Thank you for the offer, we are very grateful. We will be more than happy to take ownership and maintain the service. Would you rather transfer the ownership to PHE via GitHub, or shall I create fork and redeploy the code to our repository? I would like to ensure that your contribution is recorded in the history of the project, and I will ensure that you are adequately acknowledged in any documentation. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZVJRKOAQXZ45WTVY6EGDR7QNT3ANCNFSM4PXSZS2A> .

Answer 3 · 2020-08-07T16:15:03.000Z

You might have to make me a member of your org whilst I transfer https://docs.github.com/en/github/administering-a-repository/transferring-a-repository#repository-transfers-and-organizations On Fri, 7 Aug 2020 at 17:12, Jonathan Channon <jonathan.channon@gmail.com> wrote:

…

I’ll transfer it via Github. Glad my contribution might help someone! On Fri, 7 Aug 2020 at 16:37, Pouria Hadjibagheri ***@***.***> wrote: > @jchannon <https://github.com/jchannon> Thank you for the offer, we are > very grateful. We will be more than happy to take ownership and maintain > the service. > > Would you rather transfer the ownership to PHE via GitHub, or shall I > create fork and redeploy the code to our repository? I would like to ensure > that your contribution is recorded in the history of the project, and I > will ensure that you are adequately acknowledged in any documentation. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#5 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAZVJRKOAQXZ45WTVY6EGDR7QNT3ANCNFSM4PXSZS2A> > . >

Answer 4 · 2020-08-07T17:12:02.000Z

@jchannon I'm afraid I can't make you a member of the organisation because of the private repositories that we have. It needs authorisation from a whole lot of people - I'm sure you can imagine.

You could transfer it to me, and I will then transfer it to PHE. That's probably the easiest way to do it.

Answer 5 · 2020-08-07T17:24:57.000Z

I completely understand! I've sent a transfer request to you ready for you to transfer to PHE!

…

On Fri, 7 Aug 2020 at 18:12, Pouria Hadjibagheri ***@***.***> wrote: @jchannon <https://github.com/jchannon> I'm afraid I can't make you a member of the organisation because of the private repositories that we have. It needs authorisation from a whole lot of people - I'm sure you can imagine. You could transfer it to me, and I will then transfer it to PHE. That's probably the easiest way to do it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZVJQINEBGLUOXVR4IA2TR7QYXBANCNFSM4PXSZS2A> .

Answer 6 · 2020-08-07T17:56:37.000Z

@jchannon it's all done: https://github.com/publichealthengland/coronavirus-dashboard-api-net-sdk

It's absolutely amazing... you have even followed my design pattern which I have used across all SDKs.

All I need to do now is to create some examples for the SDK and it's ready to be added to our pool.

Once again, thank you for your contribution.

Answer 7 · 2020-08-07T18:00:14.000Z

No problem at all. I’m really glad I could do this. Brings some meaning to sitting a desk all day. If you’d like to raise any issues then I’ll happily fix them for you. I can start by setting up a CI pipeline if you like and work on releasing a package to Nuget which is .Net version of npm. Just let me know what you think is most of priority. Thanks again

…

On Fri, 7 Aug 2020 at 18:56, Pouria Hadjibagheri ***@***.***> wrote: @jchannon <https://github.com/jchannon> it's all done: https://github.com/publichealthengland/coronavirus-dashboard-api-net-sdk It's absolutely amazing... you have even followed my design pattern which I have used across all SDKs. Once again, thank you for your contribution. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZVJTKCV7KB7NW36MAVA3R7Q56HANCNFSM4PXSZS2A> .

Answer 8 · 2020-08-07T18:14:54.000Z

So the way I have been doing it for Python and JS is that I created a GitHub Actions script which runs a bunch of UnitTests and if successful, deploys the package onto its respective package manager (PyPI or NPM).

Of course releasing packages on CRAN for R is a whole different story... one which I have been writing since Friday last week, and it's still going on.

I think releasing the library on Nuget is a great idea. I haven't used C# in years - although I did write the API Manager's policies for the Coronavirus API in C#, mainly because I didn't have a choice! So any help on packing, writing the CI, etc is greatly appreciated... not that you haven't done enough so far.

I'll start working on the README file in the meantime.

Answer 9 · 2020-08-07T18:18:18.000Z

Cool! I’ll make a fork and setup GH Actions. You’ll need to create a nuget account for PHE I’d imagine. I’ve worked in .Net since 2003 so unfortunately know all the traps! However I’ve recently started working in F# to escape the C# madness!

…

On Fri, 7 Aug 2020 at 19:15, Pouria Hadjibagheri ***@***.***> wrote: So the way I have been doing it for Python and JS is that I created a GitHub Actions script which runs a bunch of UnitTests and if successful, deploys the package onto its respective package manager (PyPI or NPM). Of course releasing packages on CRAN for R is a whole different story... one which I have been writing since Friday last week, and it's still going on. I think releasing the library on Nuget is a great idea. I haven't used C# in years - although I did write the API Manager's policies for the Coronavirus API in C#, mainly because I didn't have a choice! So any help on packing, writing the CI, etc is greatly appreciated... not that you haven't done enough so far. I'll start working on the README file in the meantime. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZVJXQZ5UXMXNMABCP5ELR7RACZANCNFSM4PXSZS2A> .

Answer 10 · 2020-08-07T22:04:38.000Z

F# reminds me Haskell for some reason... I used to work with VB6 back in 98-99, then VB.net, then C#, then just gave up on them all.

Anyhow, I have already created a PHE organisational account on Nuget. The API key is in GitHub secrets under NUGET_PUBLISH_KEY.

Re the package name, we usually use a variation of uk-covid19 or uk_covid19 as package names for SDKs on their respective package managers.

Answer 11 · 2020-08-07T22:07:51.000Z

Yup it is Haskell-ish :) Don’t blame you giving it up , ha ha Thanks for setting up nuget

…

On Fri, 7 Aug 2020 at 23:04, Pouria Hadjibagheri ***@***.***> wrote: F# reminds me Haskell for some reason... I used to work with VB6 back in 98-99, then VB.net, then C#, then just gave up on them all. Anyhow, I have already created a PHE organisational account on Nuget. The API key is in GitHub secrets under NUGET_PUBLISH_KEY. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZVJWENE6OWKSXBXQLCLDR7R3AHANCNFSM4PXSZS2A> .

Answer 12 · 2020-08-07T22:09:25.000Z

Thanks Johnathan. Really appreciate your help.