UPC/ravada

Multi value LDAP field

Closed this issue · 2 comments

gmiranda commented

Describe the bug
When configuring access restrictions on a machine, multi value LDAP attributes are ignored. It looks like all the values are concatenated.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a public base machine
  2. Click on 'Access'
  3. Then on the 'LDAP' tab
  4. Set 2 attributes such as myfield = 'value1' and myfield = 'value2'
  5. Given a user with both myfield = 'value3' and myfield = 'value2', access will be denied

Expected behavior
Access should be granted to the machine given that the user ldap information contains myfield = 'value2'

Screenshots
None available, sorry

Server (please complete the following information):

  • OS: Ubuntu Server 20.04
  • Browser: Firefox
  • Ravada Version: 0.8.8-beta2

Client (please complete the following information):

  • Browser: Firefox or Chrome
  • OS: Windows and Linux
  • Spice client version: n/a

Additional context
Add any other context about the problem here.

frankiejol commented

The multi-value field is already checked and I could not replicate the problem.

ravada/lib/Ravada/Auth/User.pm

Line 395 in e85aa31

&& grep { $value eq $_ } $ldap_entry->get_value($attribute) ) {

  • 👍1
gmiranda commented

Thanks @frankiejol ! I'm closing this issue.