TADA_DepthProfilePlot future improvements - list of plots and make more concise
hillarymarler opened this issue · 4 comments
Other visualization functions including TADA_Histogram, TADA_Boxplot, and TADA_Scatterplot can create a list of plots if the input is an unfiltered data frame. Should this functionality be included in TADA_DepthProfilePlot?
Would it be useful for a plot to be created for all Monitoring Locations in the input data frame that contained results for one (or more) of the user-specified TADA.ComparableDataIdentifiers?
An additional improvement that could be considered for this function is to write an internal function that would handle the plotting of depth unit characteristics vs. other characteristics. This would make the code much more concise and easier to edit in the future.
@wokenny13 - tagging you in case the looping approach you would like to investigate for the grouped scatterplot may be useful here too.
Thoughts on horizontal lines to indicated depth category profile (Surface, Middle, Bottom)?
![image](https://private-user-images.githubusercontent.com/169296783/359196121-3bea5deb-8728-410f-87ed-e6411aaad486.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTU5NzcsIm5iZiI6MTcyNTU5NTY3NywicGF0aCI6Ii8xNjkyOTY3ODMvMzU5MTk2MTIxLTNiZWE1ZGViLTg3MjgtNDEwZi04N2VkLWU2NDExYWFhZDQ4Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwNlQwNDA3NTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iZTdkMWQ2NTQxZGUzYWYxZjEwZjQ2MzdhOGI0YTU0MjM5ZmRjYTkzMGFiNTg5NzQ1NDIwOWExNzhiNzJjMjBjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Mc9QxAL30J25HI0PErgvedwSurmkeRPxcaVCmo7IzPc)
Thoughts on a side by side plot for when the two characteristics may have unit values that differ, like with the example in the R document of Data_6Tribes_5y_Harmonized of DO and Conductivity? I pulled this random example I found of what I have envisoned.
![image](https://private-user-images.githubusercontent.com/169296783/359196640-0774001a-58ac-42ea-8b7b-7d0a66cee4ca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTU5NzcsIm5iZiI6MTcyNTU5NTY3NywicGF0aCI6Ii8xNjkyOTY3ODMvMzU5MTk2NjQwLTA3NzQwMDFhLTU4YWMtNDJlYS04YjdiLTdkMGE2NmNlZTRjYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwNlQwNDA3NTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yODM0ODkzNTc1NjViZjUzYWUxMmY5Y2JmYWUxOTgzOWE4OGQ3NjI2ZjM0OGJjOWRiMzdkMGJjYTRhYmVkODdjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._RJosWHVKeKG-QinjFq_2azVlv_5I5gjhBi3Yt-PIM0)
Both can be good, but perhaps give user the ability for a single plot or split plot argument - should consider how this will be handled in R Shiny