USLCI mappings: Not all flows mapped to flows in list error
Closed this issue · 6 comments
When running add_uuid_to_flowmapping.py
Correct - the version I pushed includes the unmappable flows.
@bl-young Running add_uuid_to_flowmapping.py actually chops off any mappings without flow matches.. when I ran it a second time I didn't get the error. Is there a reason you need to include the unmapped flows in this mapping? If we were to allow that our flowmappings tests as well as that script would have to be modifed or else they will throw errors.
We decided to include them for completeness for the Q4 database; explicit non-matches. But there is no reason why it needs to stay that way.
I've confirmed that the list before and after adding UUID matches what we expect.
Let's just preserve the non-matches somewhere else - I agree it's important to record them, but just somewhere else where it won't break the tests.
OK - would you like me to commit the revised file or do you have it there?
I've done it and closing this issue, thanks.