USEPA/flowsa

harmonized location system missing

bl-young opened this issue · 6 comments

This is needed in .flowby, assuming we want it to be maintained,

flowsa/flowsa/dataclean.py

Lines 242 to 243 in 738f06a

if df['LocationSystem'].str.contains('FIPS').all():
df = df.assign(LocationSystem='FIPS')

Without this update compare_FBS_results() will return all records as different.

Alternatively we could drop LocationSystem from the diff result, which could make sense anyway.

With compare_FBS_results() no longer using LocationSystem, should we close this issue? It seems like a positive thing in general to retain this information, in case for some reason it's needed later.

I guess the question remains whether the ultimate FBS should have FIPS (the old way) or FIPS_2015 (the new way)

I guess the question remains whether the ultimate FBS should have FIPS (the old way) or FIPS_2015 (the new way)

Agreed. My vote is for FIPS_2015, but I don't know if that would create additional problems for downstream USEEIO tools.

I like FIPS_2015 - since we are already going to have to make changes in USEEIO to aggregate data, and accept new columns, we can add to that to-do list to drop "_year" from the LocationSystem

Going ahead and closing the issue.