UUPharmacometrics/xpose

Change in error message

teunbrand opened this issue · 1 comments

Hi there,

While preparing a new release of ggplot2, our reverse dependency check showed that one of the tests in your package has broken. In particular, we've updated an error message that seemed to be part of your test here:

# Missing extension
expect_error(xpose_save(plot = plot, file = paths_1[3]),
regexp = 'Unknown graphics device')

Our suggestion remain the same as those mentioned in #210 with the following changes: this time, you could test the solutions with devtools::install_github('tidyverse/ggplot2@v3.4.2-rc'), and the expected release will be in about two weeks. I'd like to re-iterate that testing exact error messages originating in upstream packages is fragile, and that snapshot tests might limit the impact of upstream message changes.

Best wishes,
Teun

Thank you for your suggestion, fixed by @hadley in #220