Support item repairing
Opened this issue · 8 comments
I am working on adding support for 1.7 on this plugin but running to issues regarding some unavailable imports and a few others things. Would be great if you could contact me on discord to get this solved (drori#4435).
Essentials on 1.7 forge hybrids works out of the box with modded IDs support, no plugin needed
Essentials on 1.7 forge hybrids works out of the box with modded IDs support, no plugin needed
Sadly they don't. You can test this with setting up signs with the fix function.
This also doesn't solve the problem of being unable to solve problems with the current src
Sadly they don't. You can test this with setting up signs with the fix function.
Essentials itself supports all the modded blocks and items, the problem is that it can't distinguish a normal item and a tool that can be repaired.
This also doesn't solve the problem of being unable to solve problems with the current src
I think that you don't have imported the magma plugin development jar (that you can build using the instruction on their GitLab page)
I converted the project to Gradle in #5. If it will be merged, you can use it here, if not, you can use my fork.
I've merged your pull request, thank you for contributing! :)
@drori200 feel free to create a pull request too if you can address the issue with tools recognition!
Guess this can be closed off as #5 fixed everything i had. And seems like essentials is really just a pain in the butt with modded items.
As a side note, @UknownGino i'd really recommend you to add some form of communication outside of Github for minor questions that do not necessarily require an issue to be made
I'll leave this as open and change the title as maybe I can find a way to integrate item repairing in 1.12+.
Oh and you're right, I'll likely add some other comunication form like Discord or something like that. Thank you!
I'll leave this as open and change the title as maybe I can find a way to integrate item repairing in 1.12+.
Oh and you're right, I'll likely add some other comunication form like Discord or something like that. Thank you!
I have figured out that the issue was with an if statement in one of the repair methods. Removing that check doesn't seem to break anything.