UltimateHackingKeyboard/firmware

Sticky modifiers not getting cleared due to navigation modes.

kareltucek opened this issue · 5 comments

kareltucek commented

Scenario:

  • Have a "switch tab right" (Ctrl+PgDown) bound in your mod layer. Also, have mod layer navigation mode set to scrolling.
  • Switch tab and scroll immediately afterwards, before releasing the "switch tab" key.
  • Observe page getting zoomed.

Correct behavior: just as sticky mods get cleared by any other key action, I think they should be cleared by any navigation mode action.

mondalaci commented

I can't reproduce the mentioned issue.

Also, I don't understand what you mean by "navigation mode action".

kareltucek commented

Also, I don't understand what you mean by "navigation mode action".

An action produced by a navigation mode. E.g., scrolling via right-hand module.

I can't reproduce the mentioned issue.

Well, simpler setup then.

  • Map Ctrl+C on your base layer C key.
  • Change your base layer navigation mode to scroll.

Now:

  • Press and hold the c key.
  • Move your trackpoint up.

Expected behavior:

  • Ctrl+C gets emitted
  • Ctrl gets released
  • Page scrolls up

Actual behavior:

  • Ctrl+C gets emitted
  • Page zooms in
mondalaci commented

Still can't reproduce. The expected behavior happens on my side.

kareltucek commented

That's just not possible. Are you holding the c key while doing the scrolling via the right hand module?

mondalaci commented

Sorry for not being observant. I can reproduce the mentioned current behavior, and I agree with the proposed expected behavior.

  • 👍1