Section links not checked in md files
Closed this issue · 6 comments
The example below uses docker #23
- build the image of the latest linkspector from source
git clone https://github.com/UmbrellaDocs/linkspector cd linkspector docker build --build-arg LINKSPECTOR_PACKAGE= -t umbrelladocs/linkspector .
- run
linkspector check
on a test directorymkdir test cp .gitignore test # due to https://github.com/UmbrellaDocs/linkspector/issues/24 echo '[my-section](#my-section-missing)' > test/test.md echo '## My section' >> test/test.md docker run --rm -it -v $PWD/test:/app --name linkspector umbrelladocs/linkspector bash -c 'linkspector check'
Output
⠋ Configuration file not found. Using default configuration.
✨ Success: All hyperlinks in the specified files are valid.
An error due to a missing section link is expected.
It does not appear to me that this is fixed using c35eb55.
Please use the test instructions provided in the issue description (cp .gitignore test
is no longer needed), and reopen the issue if needed.
It still seems not working for me as expected with 9dc2d13
Section links in the same file are not checked.
I hope this could be implemented. This is a popular functionality looking at the number of linked issues under tcort/markdown-link-check#304, which used to implement it, but broke recently.
Top level Hopefully they are fixed. @marcindulak Let me know if you still find any issues./
links are still broken.
The test case from the issue does not fail as expected for me using 9524b58, using the Dockerfile from #23
docker build --no-cache --pull --build-arg LINKSPECTOR_PACKAGE= -t umbrelladocs/linkspector .
rm -rf test
mkdir test
echo '[my-section](#my-section-missing)' > test/test.md
echo '## My section' >> test/test.md
docker run --rm -it -v $PWD/test:/app --name linkspector umbrelladocs/linkspector bash -c 'linkspector check'
Output
⠋ Configuration file not found. Using default configuration.
✨ Success: All hyperlinks in the specified files are valid.