UniSharp/laravel-fileapi

Unable to prepare route for serialization. Uses Closure.

hbody opened this issue · 2 comments

hbody commented

I can't use artisan route:cache because of this package generates closure routes (with function).
Better will be to generate controller routes, because of with this package unable to fully optimize website.

FreedomKnight commented

It should generate routing path dynamically by its configures files.
We will try to let it can be optimized.

youchenlee commented

reference: laravel/framework#7319 (comment)

Agree with @hbody and @FreedomKnight , we should prevent closure routes since fileapi should be optimized for performance.

BTW, a nginx/apache alias or cache to the storage/app/images folder is recommended for the best performance optimization, the GET API is not necessary to go through PHP.
For example, in nginx, setup fastcgi_cache for it.

This should be mentioned in README.