UniSharp/laravel-filemanager

Logs left in code

Samvdg opened this issue · 2 comments

So there is 2 places where 'Log::' gets used

In UploadController : 38
and LfmPath : 235

In uploadcontroller we log an error. This messes with my bugreporting tool. Is this still necessery here? We throw exceptions everywhere else. In case this is intended, i will look for a different workaround but it doesn't immediately seem like this piece of code should be here.

These two logs are left intentionally, to avoid the anti-pattern: "Error should never pass silently".

But if it troubles you, I think it may be solved by using another logging channel setting in config/logging.php, exclusively for laravel file manager. How do you think?

Good to know, thank you!
This makes sense. I will check out logging.php, thank you for the suggestion!