Error when Searching in Mod Options (1.4)

Question

Error when Searching in Mod Options (1.4)

SaintBeef opened this issue 2 years ago · 19 comments

Error Message per Visual Exceptions:
Exception in Verse.Window.InnerWindowOnGUI: System.NullReferenceException: Object reference not set to an instance of an object at RimWorld.Dialog_Options.DoModOptions (Verse.Listing_Standard listing) [0x0008a] in <1ea541f48818430abd724fc665f76dc4>:0 - transpiler UnlimitedHugs.HugsLib: IEnumerable`1 HugsLib.Patches.DialogOptions_DoModOptions_Patch:InterceptWindowOpening(IEnumerable`1 instructions) at RimWorld.Dialog_Options.DoOptions (Verse.OptionCategoryDef category, UnityEngine.Rect inRect) [0x0011c] in <1ea541f48818430abd724fc665f76dc4>:0 at RimWorld.Dialog_Options.DoWindowContents (UnityEngine.Rect inRect) [0x000d5] in <1ea541f48818430abd724fc665f76dc4>:0 at Verse.Window.InnerWindowOnGUI (System.Int32 x) [0x001fd] in <1ea541f48818430abd724fc665f76dc4>:0 - transpiler net.pardeike.rimworld.lib.harmony: IEnumerable`1 VisualExceptions.ExceptionsAndActivatorHandler:Transpiler(IEnumerable`1 instructions, MethodBase original)

Error Message per Console Log:
Exception filling window for RimWorld.Dialog_Options: System.NullReferenceException: Object reference not set to an instance of an object at (wrapper dynamic-method) RimWorld.Dialog_Options.RimWorld.Dialog_Options.DoModOptions_Patch0(RimWorld.Dialog_Options,Verse.Listing_Standard) at RimWorld.Dialog_Options.DoOptions (Verse.OptionCategoryDef category, UnityEngine.Rect inRect) [0x0011c] in <1ea541f48818430abd724fc665f76dc4>:0 at RimWorld.Dialog_Options.DoWindowContents (UnityEngine.Rect inRect) [0x000d5] in <1ea541f48818430abd724fc665f76dc4>:0 at (wrapper dynamic-method) Verse.Window.Verse.Window.InnerWindowOnGUI_Patch0(Verse.Window,int) UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch4 (string) (wrapper dynamic-method) Verse.Window:Verse.Window.InnerWindowOnGUI_Patch0 (Verse.Window,int) UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)

Steps to Reproduce:

Enter Main Menu
Go into Settings > Mod Settings
Use the search bar, type in anything

Answer 1 · 2022-11-09T18:38:51.000Z

Confirmed, looks like something introduced by a recent update.
Thanks for the report.

Answer 2 · 2022-11-09T18:47:09.000Z

No problem. Thanks for the hard work!

Answer 3 · 2022-12-06T00:37:28.000Z

Oh sweet you guys are already on top of it, should have suspected, keep it up!

Answer 4 · 2023-03-22T19:16:48.000Z

This appears to still be an issue? Unsure if any information is needed but I've ran into this issue repeatedly, recently. Currently running with just Hugslib as the only mod installed and getting this exact error.

Answer 5 · 2023-03-22T19:23:17.000Z

This appears to still be an issue? Unsure if any information is needed but I've ran into this issue repeatedly, recently. Currently running with just Hugslib as the only mod installed and getting this exact error.

Yes the mod author has unfortunately retired from hugslib, authors are now working to remove hugslib from their dependencies. Unless there is a third party fix this may just be a permanent issue

Answer 6 · 2023-04-21T03:37:37.000Z

Where did they announce their retirement?

Answer 7 · 2023-06-19T01:04:22.000Z

It doesn't really matter whether retirement was announced, the bottomline is this Mod Options Search field bug is still an issue despite several people giving pull requests that would fix it. Nobody is here to review and merge the fixes, so it stays stuck.

At a glance, this library project seems to have an open source license, so I wonder why anyone hasn't forked it after so many months. Putting out a temporary fork with patches seems like a lot less work than trying to remove it from being included in so many dependencies of mods.

Answer 8 · 2023-06-19T03:23:19.000Z

I mean I'm sure many would love to, but are not coders

…

On Sun, Jun 18, 2023, 8:04 PM jeois ***@***.***> wrote: It doesn't really matter whether retirement was announced, the bottomline is this Mod Options Search field bug is still an issue despite several people giving pull requests that would fix it. Nobody is here to review and merge the fixes, so it stays stuck. At a glance, this library project seems to have an open source license, so I wonder why anyone hasn't forked it after so many months. Putting out a temporary fork with patches seems like a lot less work than trying to remove it from being included in so many dependencies of mods. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALUUPJYISLTPFD2FDQNIMATXL6QSBANCNFSM6AAAAAAR3XG2NA> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 9 · 2023-06-19T05:20:56.000Z

I mean I'm sure many would love to, but are not coders

If nobody were coders, then there wouldn't be 2 pull requests which both tried to fix this issue already. You don't need to code to merge those pulls and fork this temporarily.
Somebody already did the coding 6 months ago, but nobody approved it. You can review PR #94 and #97 if you don't believe me.

I think you misunderstood the problem. It's less about coding and more just that modders are scared to collaborate because each modder is afraid about stepping on each other's toes because some mods have weird custom licenses. However, in the open source community, nobody cares about forks. Fortunately, this library's original author gave us permission, so there's no reason to be timid.

Answer 10 · 2023-06-19T05:30:56.000Z

if you say so

…

On Mon, Jun 19, 2023, 12:21 AM jeois ***@***.***> wrote: I mean I'm sure many would love to, but are not coders If nobody were coders, then there wouldn't be 2 pull requests which both tried to fix this issue already. You don't need to code to merge those pulls and fork this temporarily. Somebody already did the coding 6 months ago, but nobody approved it. You can review PR #94 <#94> and #97 <#97> if you don't believe me. I think you misunderstood the problem. It's less about coding and more just that modders are scared to collaborate because each modder is afraid about stepping on each other's toes because some mods have weird custom licenses. However, in the open source community, nobody cares about forks. Fortunately, this library's original author gave us permission, so there's no reason to be timid. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALUUPJ4PRXZH4ILPSYCNICTXL7OUFANCNFSM6AAAAAAR3XG2NA> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 11 · 2023-06-19T05:47:19.000Z

if you say so

if I'm wrong, there wouldn't be fixes already.

Answer 12 · 2023-07-31T15:32:22.000Z

Has it been resolved? I am still encountering this error.

Answer 13 · 2023-07-31T15:36:22.000Z

No, the mod is dead in the water and most modpacks are attempting to move away from using hugslib since it’s no longer going to be updated

…

On Mon, Jul 31, 2023 at 10:32 AM hjhjfhjhujhh ***@***.***> wrote: Has it been resolved? I am still encountering this error. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALUUPJ23OCKF63B2Q6V7UMLXS7FZDANCNFSM6AAAAAAR3XG2NA> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 14 · 2023-08-04T01:25:57.000Z

I don't get it. If your mod still relies on this lib, then there's no reason not to fork it and apply PR #74 or #79, so at least this mod option bug is fixed. It'd be one thing if nobody was interested at all, but 2 people already submitted patches. I suppose those other mods which depend on this are outdated too.

On the other hand, I think "Mod Options Sort" does make the error messages go away, so this issue has a workaround.

Answer 15 · 2023-08-04T02:00:44.000Z

Probably because no one wants to have a dependency that is no longer going to be supported, what happens when the game updates again and things break even more? I certainly wouldn’t want to rely on someone else to pick up the slack when I can just go without the dependency. If you really really really want hugslib to continue though, why don’t you just take up the mantle yourself? Then you could keep the library alive and relevant

…

On Thu, Aug 3, 2023 at 8:26 PM jeois ***@***.***> wrote: I don't get it. If your mod still relies on this lib, then there's no reason not to fork it and apply PR #74 <#74> or #79 <#79>, so at least this mod option bug is fixed. It'd be one thing if nobody was interested at all, but 2 people already submitted patches. I suppose those other mods which depend on this are outdated too. On the other hand, I think "Mod Options Sort" does make the error messages go away, so this issue has a workaround. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALUUPJ7F2YOO7U7BO5PTY2TXTRFTBANCNFSM6AAAAAAR3XG2NA> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 16 · 2023-08-04T02:55:13.000Z

You misunderstood me again.
Firstly, if everyone already removed huglib as a dependency, we wouldn't need to discuss it, so that's a non sequitur and besides the point. Clearly, there are still mods which use this, and I'm suggesting they package a patched version with their mod. Sure, if they can replicate functions without this library, then of course that's also good, but in my opinion, that's more time consuming and probably why they haven't gotten around to doing it yet.

I don't worry about other breaks in the future because they'll happen regardless of whether we apply the patches or not. This thread isn't necessarily about potential issues down the line, which aren't contingent on the changes proposed anyway. Yes, the likelihood of something else breaking is high, but until other mod authors actually remove it or we stop using those mods, then we still have to deal with it for the time being.

In any case, I'm running half a dozen mods which use hugslib, and with Mod Options Sort, which fixes this issue, there hasn't been other issues so far. So when something does break, I'll worry about it then.

Answer 17 · 2023-08-04T04:08:49.000Z

You certainly seem to be worrying about it a lot now tbh

…

On Thu, Aug 3, 2023 at 9:55 PM jeois ***@***.***> wrote: You misunderstood me again. Firstly, if everyone already removed huglib as a dependency, we wouldn't need to discuss it, so that's a non sequitur and besides the point. Clearly, there are still mods which use this, and I'm suggesting they package a patched version with their mod. Sure, if they can replicate functions without this library, then of course that's also good, but in my opinion, that's more timing consuming and probably why they haven't gotten around to doing it yet. I don't worry about other breaks in the future because they'll happen regardless of whether we apply the patches or not. This thread isn't necessarily about potential issues down the line, which aren't contingent on the changes proposed anyway. Yes, the likelihood of something else breaking is high, but until other mod authors actually remove it or we stop using those mods, then we still have to deal with it for the time being. In any case, I'm running half a dozen mods which use hugslib, and with Mod Options Sort, which fixes this issue, there hasn't been other issues so far. So when something does break, I'll worry about it then. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALUUPJ3M7DYHSSKBQYBK46LXTRQBXANCNFSM6AAAAAAR3XG2NA> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 18 · 2023-08-04T06:05:55.000Z

If you don't use it anymore, then of course you don't care. I'm just trying to help people with this issue. Pull Request #97 really does fix it, or you can use Mod Options Sort.

Answer 19 · 2024-05-26T17:48:21.000Z

Should be resolved as part of the 1.5 update.