UoMResearchIT/RSESkillsGraph

Fix invalid interests

ianhinder opened this issue · 5 comments

ianhinder commented

Please could @Adina-Rahim @PhilBradbury @PBarnby @TheresaTeng @ajerrison-manchester @nigeldgreen @Scottan @cjfullerton @DrJonnyT @awaisk0 @CatherineMcGuire @emmasimp @Josh-Woodcock @louiselever take a look at their people.json entries, and fix the following to be wikipedia article titles? I've already fixed the ones I could do, but I wasn't sure what to do about the remaining ones.

If it's not possible, as you really want to list something for which wikipedia doesn't have a specific article, we can create an additional "allowed" list.

Invalid titles:
  Alexa Skill Development (Adina Rahim)
  Analysis of Large Graphs: Trust Rank and Webspam (Adina Rahim)
  Application design (Phil Bradbury, Patricia Barnby, Theresa Teng, Andrew Jerrison, Nigel Green)
  Association Rule Mining (Adina Rahim)
  Chemistry-Climate modelling (Scott Archer-Nicholls)
  Correctness testing (Ian Hinder)
  Deep Learning for Computer Vision (Adina Rahim)
  FCM make (Scott Archer-Nicholls)
  GitHub Actions (Chris Fullerton)
  Natural environmental (Jonny Taylor)
  React Testing Library (Awais Khan)
  Streamlit (Catherine McGuire, Emma Simpson)
  VRTK (Josh Woodcock, Louise Lever)
  vis.js (Andrew Jerrison)

Note that the tests are failing until these are fixed, so don't assume if you make a change that the failing test is caused by you!

DrJonnyT commented

I've made a new PR branch for my edit, but it doesn't seem to have run any actions- was it supposed to? (helps if you actually make the PR)

ianhinder commented

Haha! It also doesn't show the check immediately; you have to refresh the page after creating the PR to even see that it is waiting to run the check!

rowleya commented

After some recent PRs, the list is now:

An option for a fix would be to add an exception list for when Wikipedia doesn't cover the topic in question. I would then suggest the following changes (where exception means it should go in the exception list):

  • Alexa Skill Development (@Adina-Rahim) 🠂 Amazon Alexa or Alexa Skills exception
  • Analysis of Large Graphs: Trust Rank and Webspam (@Adina-Rahim) 🠂 TrustRank and WebSpam exception
  • Application design (@PBarnby) 🠂 Software Desgin or User Interface Design or Mobile app development
  • Association Rule Mining (@Adina-Rahim) 🠂 Association Rule Learning
  • Chemistry-Climate modelling (@Scottan) 🠂 Climate Model
  • Deep Learning for Computer Vision (@Adina-Rahim) 🠂 Convolutional neural network and/or Computer vision
  • FCM make (@Scottan) 🠂 Fortran or _FCM Make (software) _ exception
  • GitHub Actions (@cjfullerton) 🠂 GitHub Actions exception
  • Software Carpentry (@Josh-Woodcock) 🠂 The Carpentries
  • Streamlit (@CatherineMcGuire) 🠂 _Streamlit (software) _ exception
  • VRTK (@Josh-Woodcock) 🠂 Virtual Reality Toolkit (software) exception

This firstly would require an exception list, but if anyone tagged wants to make changes to the above, please do suggest alternatives, or make PRs if you can find Wikipedia suggestions that match better.

ianhinder commented

@rowleya The above proposal looks good to me. Now that we have the ability to add exceptions, would you have some time to make a PR for the above? We could ask for a final check on the PR from the tagged people above before we merge it.

rowleya commented

PR Done - note it still fails on canonicalisation.