Notations on New Approach
andreherberth opened this issue · 5 comments
I am rewriting pockethold. Mainly, what I want is to make it more robust.
First of, it will use a .lock file and "composer install". This let's composer consentrate on just downloading the specific packages. It should make composer timeout less likely. It will also be easier to re-run if composer times out.
Second, the installer will check requirements before proceeding.
Third, UI will be updated with better information. Instead of progress tracking, I have decided I want to show the composer.log instead, updating it every 6 seconds or so.
Before cleanup (Both on success and failure), the option to download the logs will be present.
My main issue would be the UI. My JS skills is somewhat limited (Not that my PHP skills are that much better, but still).
I will update this ticket during the planing phase.
Current Tasks:
- Proof of concept (.lock file) (non UI test)
Investigating the possibility of using a composer.lock file for the install. Need to research more.
Let's say I install it the recommended way on a test-bed, and the use the .lock file generated to run composer install. If I understand composer enough, it should ease the workload, and memory footprint of the task.
@luceos sorry for asking, but do you know if this would be feasible? Or would the lock-file contain system related information that could make it incompatible with other systems?
No, the lock is safe to use on any environment as long as the php version is the same. Composer will trigger errors whenever other requirements aren't met (eg php extensions missing).
Updated first post.
Precompile of version 0.1.0.beta7: https://github.com/andreherberth/pockethold/files/1430027/flarumnew.zip
Will build version 0.1.0.beta.7.1 shortly.
Super-seeded by #33