Youtube/Vimeo Video Support
Opened this issue · 6 comments
Hello @VLZH
First of all, thank you for this amazing wrapper. I saw you're planning to work in video support and I really wanted to help you with that, cause I'm working on a project in React.js that needs video support in a lightbox and I don't found anything better to use instead of lightGallery :(
What do you think about it? Maybe we can discuss more this implementation and maybe I could help you with that. Did you already develop something for this resource?
@dougfabris Thank you for this issue, i will implement video support soon.
Nice to hear from you @VLZH I was checking the code and I found a way to use youtube/Vimeo videos just passing the video URL in "src" of LightgalleryItem component's prop. Doing it we'll face an error in lg-video dependency related to this pull request . I did the correction locally and it works, but maybe will be necessary to wait for this merge to publish the video feature, I don't know... If you need help with something, let me know.
Nice to hear from you @VLZH I was checking the code and I found a way to use youtube/Vimeo videos just passing the video URL in "src" of LightgalleryItem component's prop. Doing it we'll face an error in lg-video dependency related to this pull request . I did the correction locally and it works, but maybe will be necessary to wait for this merge to publish the video feature, I don't know... If you need help with something, let me know.
@dougfabris, it does support YouTube videos and it worked great up until some moment of time when we stumbled upon this issue, after my PR will be accepted I'll create another one here to bump the version of the dependency.
@svbutko I suggest to include this youtube/Vimeo support in documentation with an example too. I can help with that if you guys need it. PS: In my opinion, it's the only good solution for lightbox for React.js that supports images and videos.
Any progress on this? Really looking forward to the video support.