TestInsight and file name clashes
Closed this issue · 2 comments
luebbe commented
Two things I noticed while working on the two fixes:
- The test program doesn't compile when testinsight is defined. Some defines have to be juggled around to fix this
- both NUnit and JUnit XML loggers have the same default file name
dunit-results.xml
which results in a file access error when you add both loggers to the project without overriding the file name.
I think:
- should be fixed and
- could be fixed, by changing
dunit-results.xml
to e.g.dunit-results.junit.xml
anddunit-results.nunit.xml
, but this will probably break existing CI configurations.
vincentparrett commented
- This is fixed now
- This will break existing setups. Also it would be unusual to have both an NUnit logger and a JUnit Logger in the same app. You can supply an output filename to the logger constructor if you need to change it.
luebbe commented
- Thanks, saw it
- Not a real problem as you say, becaue normally only one of the two loggers would be used, I just stumbled across it, because I added a JUnit logger without removing the NUnit logger when I worked on the JUnit output :)