Can't get `,` to trigger major mode?
Closed this issue · 5 comments
Bug description
I noticed that in 0.8.3, , should be able to trigger major mode. Doesn't seem like it's working for me, and I'm not sure why. My VSCode settings are here if you'd like to take a look at them (apologies in advance, there is a lot going on there): https://github.com/macintacos/dotfiles/tree/trunk/vscode
I know I can just go to the settings.jsonc file copy/paste it into my own settings myself, but I think I'd rather make sure it's working the "proper" way. Any pointers on how to debug it?
To Reproduce
- Install the extensions
- Go to a filetype that is supported with major mode (like Go)
- Hit
,
Expected behavior
The major mode menu would open up for the language you're in.
System information
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300) |
| GPU Status | 2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled |
| Load (avg) | 4, 2, 2 |
| Memory (System) | 32.00GB (0.54GB free) |
| Process Argv | --crash-reporter-id c6914155-166f-4175-88b3-886232e620cd |
| Screen Reader | no |
| VM | 0% |
Extensions (156)
| Extension | Author (truncated) | Version |
|---|---|---|
| better-comments | aar | 2.1.0 |
| html-snippets | abu | 0.2.1 |
| scss-lint | ada | 0.1.10 |
| vscode-javascript-snippet-pack | aka | 0.1.6 |
| Bookmarks | ale | 11.4.0 |
| project-manager | ale | 11.3.1 |
| vscode-bazel | Baz | 0.4.0 |
| search-crates-io | bel | 1.2.1 |
| color-info | bie | 0.5.1 |
| emojisense | bie | 0.8.0 |
| github-markdown-preview | bie | 0.0.2 |
| markdown-checkbox | bie | 0.1.3 |
| markdown-emoji | bie | 0.0.9 |
| markdown-preview-github-styles | bie | 0.1.6 |
| markdown-yaml-preamble | bie | 0.0.4 |
| vscode-fish | bma | 1.0.20 |
| file-browser | bod | 0.2.10 |
| htmltagwrap | bra | 0.0.7 |
| vscode-tailwindcss | bra | 0.4.3 |
| language-hugo-vscode | bud | 1.2.0 |
| better-toml | bun | 0.3.2 |
| npm-intellisense | chr | 1.3.1 |
| path-intellisense | chr | 2.3.0 |
| gotoanything | Cma | 0.4.1 |
| gitignore | cod | 0.6.0 |
| bracket-pair-colorizer-2 | Coe | 0.2.0 |
| disableligatures | Coe | 0.0.10 |
| compulim-vscode-closetag | Com | 1.2.0 |
| vscode-svgviewer | css | 2.0.0 |
| postcss | css | 1.0.9 |
| transformer | dak | 1.9.0 |
| vscode-markdownlint | Dav | 0.37.2 |
| vscode-eslint | dba | 2.1.13 |
| vscode-dash | dee | 2.4.0 |
| confluence-markup | den | 0.1.8 |
| vscode-deno | den | 2.3.2 |
| xml | Dot | 2.5.1 |
| viml | dun | 0.1.7 |
| gitlens | eam | 10.2.2 |
| vscode-html-css | ecm | 0.2.3 |
| EditorConfig | Edi | 0.15.1 |
| vscode-npm-script | eg2 | 0.3.13 |
| LogFileHighlighter | emi | 2.9.0 |
| vscode-great-icons | emm | 2.1.58 |
| vsc-material-theme-icons | equ | 1.2.0 |
| prettier-vscode | esb | 5.7.1 |
| vscode-go-test-adapter | eth | 0.1.3 |
| copy-relative-path-and-line-numbers | ezf | 0.2.8 |
| vscode-git-history | fab | 2.0.5 |
| vscode-open-in-github | fab | 1.2.3 |
| file-icons | fil | 1.0.26 |
| vscode-firefox-debug | fir | 2.9.1 |
| vscode-npm | fkn | 3.3.0 |
| auto-close-tag | for | 0.5.9 |
| code-runner | for | 0.11.1 |
| shell-format | fox | 7.0.1 |
| sort-json-array | fvc | 2.0.3 |
| nightswitch | gha | 1.1.0 |
| vscode-sublime-merge | gio | 1.2.0 |
| vscode-pull-request-github | Git | 0.20.1 |
| go | gol | 0.18.0 |
| gc-excelviewer | Gra | 3.0.40 |
| todo-tree | Gru | 0.0.186 |
| terraform | has | 2.2.3 |
| vscode-test-explorer | hbe | 2.19.1 |
| npm-dependency-links | her | 1.2.0 |
| headwind | hey | 1.7.0 |
| vscode-settings-cycler | hoo | 1.0.1 |
| output-colorizer | IBM | 0.1.2 |
| smarty | imp | 0.3.0 |
| customize-ui | ioc | 0.1.49 |
| monkey-patch | ioc | 0.1.11 |
| path-autocomplete | ion | 1.15.0 |
| fuzzy-search | jac | 0.0.3 |
| RelativePath | jak | 1.4.0 |
| TypeScriptImport | kev | 1.17.0 |
| json2csv | kha | 0.0.1 |
| vscode-gutter-preview | kis | 0.26.2 |
| vscode-format-context-menu | lac | 1.0.4 |
| rpm-spec | Lau | 0.3.1 |
| vscode-simple-icons | Lau | 1.13.5 |
| vscode-fix-checksums | leh | 1.1.0 |
| node-module-intellisense | lei | 1.5.0 |
| expand-region | let | 0.1.4 |
| bash-ide-vscode | mad | 1.11.0 |
| rust-analyzer | mat | 0.2.360 |
| Lisp | mat | 0.1.10 |
| rainbow-csv | mec | 1.7.1 |
| HTMLHint | mka | 0.10.0 |
| mongodb-vscode | mon | 0.2.1 |
| vscode-less | mrm | 0.6.3 |
| vscode-docker | ms- | 1.7.0 |
| vscode-kubernetes-tools | ms- | 1.2.1 |
| python | ms- | 2020.9.114305 |
| vscode-pylance | ms- | 2020.10.2 |
| cpptools | ms- | 1.0.1 |
| vscode-typescript-tslint-plugin | ms- | 1.2.3 |
| debugger-for-chrome | msj | 4.12.11 |
| vscode-paste-image | mus | 1.0.4 |
| color-highlight | nau | 2.3.0 |
| vetur | oct | 0.28.0 |
| indent-rainbow | ode | 7.4.0 |
| vscode-nunjucks-formatter | oki | 0.1.3 |
| fix-json | oli | 0.1.2 |
| markdown-checkbox | PKi | 1.7.0 |
| material-icon-theme | PKi | 4.3.0 |
| vscode-css-peek | pra | 4.0.0 |
| text-power-tools | qcz | 1.17.0 |
| ruby | reb | 0.27.0 |
| vscode-xml | red | 0.13.0 |
| vscode-yaml | red | 0.11.1 |
| explorer-exclude-vscode-extension | Red | 1.2.0 |
| shellman | Rem | 4.7.0 |
| vscode-sort-json | ric | 1.18.1 |
| synthwave-vscode | Rob | 0.1.8 |
| bash-debug | rog | 0.3.9 |
| zsh-debug | rog | 0.1.3 |
| nunjucks | ron | 0.3.0 |
| codeui | rya | 0.2.0 |
| partial-diff | ryu | 1.4.1 |
| multi-command | ryu | 1.4.0 |
| vscode-javascript-booster | sbu | 14.0.1 |
| crates | ser | 0.5.3 |
| code-settings-sync | Sha | 3.4.3 |
| vscode-brewfile | sha | 1.0.0 |
| trailing-spaces | sha | 0.3.1 |
| mdx | sil | 0.1.0 |
| vscode-fileutils | sle | 3.3.3 |
| snipsnap-vscode | sni | 1.1.0 |
| control-snippets | svi | 1.9.1 |
| vscode-markdown-paste-image | tel | 0.12.3 |
| shellcheck | tim | 0.12.1 |
| alex-linter | tla | 0.6.5 |
| go-to-method | tri | 0.2.0 |
| sort-lines | Tyr | 1.9.0 |
| errorlens | use | 3.2.3 |
| remove-empty-lines | use | 0.0.6 |
| vscode-lldb | vad | 1.6.0 |
| vscode-icons | vsc | 11.0.0 |
| vim | vsc | 1.17.1 |
| gistfs | vsl | 0.1.8 |
| vspacecode | VSp | 0.8.3 |
| whichkey | VSp | 0.8.2 |
| file-icons-mac | way | 1.0.1 |
| vscode-icons-mac | way | 7.25.3 |
| vscode-todo-highlight | way | 1.0.4 |
| twig | wha | 1.0.2 |
| vscode-ruby | win | 0.27.0 |
| change-case | wma | 1.0.0 |
| better-align | wwm | 1.1.6 |
| clang-format | xav | 1.9.0 |
| vs-code-wiki | Yun | 0.5.0 |
| markdown-all-in-one | yzh | 3.3.0 |
| material-theme | zhu | 3.9.3 |
| html-css-class-completion | Zig | 1.19.0 |
| vscode-open-in-github | ziy | 1.3.6 |
(13 theme extensions excluded)
You need to either run config setting command or put https://github.com/VSpaceCode/VSpaceCode/blob/master/src/configuration/settings.jsonc#L16-L23 in vim.normalModeKeyBindingsNonRecursive and vim.visualModeKeyBindingsNonRecursive manually
@stevenguh ah okay, didn't realize there was that command. Do you think that should be added to the docs site? I'm surprised it didn't "just add it" when I updated (although it's understandable why it didn't).
The config commands are listed on https://vspacecode.github.io/docs/. Let me know where we can improve, or open an PR directly ;)
As far as the "just add it" comment, I agree that we should do better than letting people know and it is tracked by VSpaceCode/VSpaceCode#105. I am thinking at least a notification that has button to update their config automatically instead of having users to check changelog manually.
I was thinking of mentioning it in the Major mode page here, since that's where it mentioned , being a thing the most prominently (or, at least, that's where I went to see if I had just misconfigured something): https://vspacecode.github.io/docs/major-mode
Will open a PR soon to have that added 🙂