Angular 10 issue -> optimization bailouts

Question

Angular 10 issue -> optimization bailouts

Seharad opened this issue 5 years ago · 63 comments

WARNING in /../node_modules/ng2-pdf-viewer/ivy_ngcc/fesm2015/ng2-pdf-viewer.js depends on pdfjs-dist/build/pdf. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

JohnnyTMD commented 4 years ago

same here

PedroS5499 commented 4 years ago

any news?

icecoldfire commented 2 years ago

Not stale

Answer 1 · 2020-07-08T09:50:36.000Z

same here, but put in angular.json like they said in official guide

[https://angular.io/guide/build#configuring-commonjs-dependencies]

"options": {
						"allowedCommonJsDependencies": [",
							"moment-business",
							"ng2-pdf-viewer",
							"pdfjs-dist/build/pdf",
							"pdfjs-dist/web/pdf_viewer"
						],

Answer 2 · 2020-07-08T10:00:32.000Z

this is just for ignoring the warnings. But the goal should be to get rid of the warnings in general.

Answer 3 · 2020-07-13T17:58:13.000Z

Ignoring errors is not the way to go.

Answer 4 · 2020-08-03T13:39:56.000Z

same here, any news?

Answer 5 · 2020-08-06T15:28:58.000Z

pdfjs is not written with es modules, but they made a es module wrapper available that could be used in the meantime: https://www.npmjs.com/package/@bundled-es-modules/pdfjs-dist

for more info: mozilla/pdf.js#10317

Answer 6 · 2020-08-07T21:04:16.000Z

@saithis thanks for pointing the right issue
@bundled-es-modules/pdfjs-dist seems to be outdated

Answer 7 · 2020-10-06T21:57:13.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 8 · 2020-11-11T18:27:34.000Z

Can we re-open this one?

Answer 9 · 2020-11-12T20:29:27.000Z

@mrmokwa yes indeed

Answer 10 · 2020-11-21T09:00:32.000Z

I hate this Warning :'(

Answer 11 · 2020-11-29T13:11:36.000Z

Any updates?

Answer 12 · 2020-12-15T18:28:33.000Z

Any updates on this?

Answer 13 · 2020-12-25T10:26:18.000Z

This warning is really annoying any pending fixes for this yet?

Answer 14 · 2020-12-29T10:01:47.000Z

I m able to fix the issue by adding commonJsdependency property in the angular.json

angular.json

Inside Build command there is an option
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"allowedCommonJsDependencies": ["ng2-pdf-viewer"],
}

Answer 15 · 2020-12-29T10:10:03.000Z

I m able to fix the issue by adding commonJsdependency property in the angular.json

angular.json

Inside Build command there is an option
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"allowedCommonJsDependencies": ["ng2-pdf-viewer"],
}

this is not a fix, this is an ignore.

Answer 16 · 2020-12-29T17:40:53.000Z

@VadimDez When I tried to build you library from source, I ran into the same problem. Even worse: the require() statements work in the ng2-pdf-viewer demo project, but they failed to work after copying the dist folder to my test project.

Can we get rid of the require() statements? Angular's stopped supporting require.js. It'd be nice to use an import statement instead. Or we could load pdf.js and viewer.js directly. That'd allow for loading these big files lazily.

Answer 17 · 2021-01-24T13:18:07.000Z

any updates?

Answer 18 · 2021-02-18T08:13:32.000Z

all require()s have been removed

Answer 19 · 2021-04-19T09:07:43.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 20 · 2021-04-21T09:59:09.000Z

@VadimDez
If i understand this correctly, unless an ECMAScript module bundle version of ng2-pdf-viewer is released, we have to add ng2-pdf-viewer to allowedCommonJsDependencies to ignore this warning? 🤔

Do you think an ECMAScript module bundle version of ng2-pdf-viewer will be available in the future? 🔭

Answer 21 · 2021-06-20T10:48:32.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 22 · 2021-06-21T13:06:50.000Z

Bump to remove stale.

Answer 23 · 2021-07-12T00:29:52.000Z

Has anyone actually found a solution to this? Even if its temporary workaround?

Answer 24 · 2021-08-04T06:03:42.000Z

mozilla/pdf.js#10317

Still open :( Hope they will provide it.

Answer 25 · 2021-08-13T19:42:25.000Z

Not to sound like a broken record, but has there been any progress on this issue?

Answer 26 · 2021-09-16T02:40:54.000Z

first create an ngcc.config.js file on the root => https://githubmemory.com/repo/VadimDez/ng2-pdf-viewer/issues/754

and then allowedCommonJsDependencies

"allowedCommonJsDependencies": [
"ng2-pdf-viewer",
"pdfjs-dist"
]

it work for my project

Answer 27 · 2021-09-22T14:55:43.000Z

Any progress? It seems like this type of module causes my initial bundle to have extra 500 Kb, while I'm using it only in lazy loaded modules so I'm expecting it not to be present in an initial bundle

Answer 28 · 2021-09-28T11:34:33.000Z

Also hoping for any updates on this.

\node_modules\ng2-pdf-viewer_ivy_ngcc_\fesm2015\ng2-pdf-viewer.js depends on 'pdfjs-dist/es5/build/pdf'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Answer 29 · 2021-11-27T11:38:07.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 30 · 2021-11-27T11:42:09.000Z

nono not close 😂

Answer 31 · 2021-12-03T19:27:29.000Z

Is using https://www.npmjs.com/package/@bundled-es-modules/pdfjs-dist still a viable solution for this issue?

Answer 32 · 2022-01-08T06:32:01.000Z

Our project is clean outside of this particular issue.

Is this being worked on?

Answer 33 · 2022-01-11T16:30:33.000Z

+1 any news? Thanks!

Answer 34 · 2022-03-12T22:07:35.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 35 · 2022-03-12T22:39:38.000Z

nono not close 😂

Answer 36 · 2022-03-13T08:53:00.000Z

nono not close 😂

😂

Answer 37 · 2022-03-24T07:48:57.000Z

I get the message fesm2020 depends on 'pdfjs-dist/legacy/build/pdf

I could be wrong, but in the readme of pdfjs-dist it says, that this version is older browsers or environments without the support for modern features such as async/wait support.

So the only way to remove that message, would be to start using the modern pdfjs version in pdfjs-dist/build/pdf and not the legacy in ng2-pdf-viewer. Of course with the usual upgrade problems.

Is this a viable option, or planning in the near future?

Answer 38 · 2022-03-24T08:00:47.000Z

Ngl I don't even remember what this was about 🤣

Answer 39 · 2022-03-24T08:03:39.000Z

It's the same on angular 13, it just complains about the optimization bailout when you do a ng-serve. It's still something that needs to be fixed in the foreseeable future and not ignored.

Answer 40 · 2022-03-30T17:04:44.000Z

In short it has to be addressed since it prevent effective trees-shake and eventually add over 150KB to the GZIPPED package.

Answer 41 · 2022-05-10T03:18:39.000Z

Any progress?

Answer 42 · 2022-05-10T17:08:31.000Z

This doesn't depend only from VadimDez... This issue probably won't be ever done

mozilla/pdf.js#10317 (comment)

...we don't want to add even more builds and we also want to support both browsers and Node.js environments with the same builds.

Answer 43 · 2022-05-10T18:02:55.000Z

Node is slowly but surely transitioning from commonjs to modules

Answer 44 · 2022-05-10T18:59:35.000Z

@VadimDez I could donate the lazy loading algorithm of my own library, ngx-extended-pdf-viewer. The disadvantage of my approach is there's no tree shaking. The huge pdf.js files are loaded as-is. On the plus side, you get lazy loading. In most cases, this outweighs the disadvantage of having bigger files.

Interested?

Best regards,
Stephan

Answer 45 · 2022-05-11T07:03:20.000Z

Sounds good, as long as it doesn't add weight to the main package the zise doesn't matter. Zoom meeting for example is nearly 5MB but allow lazy loading. Since PDF has weight, user won't expect expect loading to be immediately.

…

On Tue, May 10, 2022, 21:59 Stephan Rauh ***@***.***> wrote: @VadimDez <https://github.com/VadimDez> I could donate the lazy loading algorithm of my own library, ngx-extended-pdf-viewer. The disadvantage of my approach is there's no tree shaking. The huge pdf.js files are loaded as-is. On the plus side, you get lazy loading. In most cases, this outweighs the disadvantage of having bigger files. Interested? Best regards, Stephan — Reply to this email directly, view it on GitHub <#624 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD2TRA6LHHJODL2ZZPVGDBTVJKW2LANCNFSM4OIVAKTQ> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 46 · 2022-07-10T14:15:33.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 47 · 2022-07-10T14:19:16.000Z

Hahahaha nah g you ain't gonna do that. This is gonna stay open until it doesn´t get fixed

Answer 48 · 2022-07-25T11:26:47.000Z

Its not stale.

I am having issue as well.

Answer 49 · 2022-09-22T18:44:45.000Z

we are still having this issue as well, which is how I got here.. really hope this gets addressed or may have to go digging for another option, though I've already tried a number of them.

Answer 50 · 2022-11-27T07:12:13.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 51 · 2022-11-27T08:17:27.000Z

What is the point of the stale bot? If just spams everyone twice every month instead of just getting a message when there is real progress...

Answer 52 · 2022-12-16T06:04:28.000Z

It's even occurring in angular 14 version. Any fix yet ?

Answer 53 · 2023-01-11T15:30:35.000Z

It's still happening in Angular 15 version...any plans for an update please?

Answer 54 · 2023-03-06T11:30:14.000Z

It's still happening in Angular 15.2 version

Answer 55 · 2023-05-14T19:39:12.000Z

Angular 16 and still happening :(

Answer 56 · 2023-08-18T04:34:11.000Z

Somebody please give me the solution....

Answer 57 · 2023-10-16T18:04:58.000Z

Any progress? :/

Answer 58 · 2023-10-25T15:49:50.000Z

I would love to see this fixed

Answer 59 · 2023-12-10T09:36:32.000Z

Angular 17 and still happening :(

Answer 60 · 2024-01-24T03:29:23.000Z

Would love to see this fixed