VadimDez/ng2-pdf-viewer

Annotations not shown correctly

RobinBomkampDv opened this issue ยท 19 comments

Bug Report or Feature Request (mark with an x)
- [ ] Regression (a behavior that used to work and stopped working in a new release)
- [x] Bug report -> please search issues before submitting
- [ ] Feature request
- [ ] Documentation issue or request

Existing comments in a pdf file are not shown correctly.
The image is not correct and the text "[{{type}} Annotation]" is shown.
If you hover the comment it is showing the correct comment, but without time and date. (Only placeholders are shown.)

image

I have tested this with the current demo page. A test with pdfjs-dist is working.

Example file:
1 with comment.pdf

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Hey there, this is still an issue for us.

Akxe commented

Indeed, here is another PDF with annotations problem: Faktura - ISCOD.pdf

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Still relevant.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

And again. Still relevant.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Not stale

Akxe commented

Indeed, please, it is very annoying :(
The vanilla pdf.js does not do this

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Still relevant. :)

Indeed, this is still relevant. Date and time do not render.
image

Based on this: https://stackoverflow.com/questions/69633500/how-to-enable-annotation-in-pdfjs-viewer?rq=1 which is same problem with ng2-pdfjs-viewer it seems like issue here is with l10n :)

Can someone look at it? This ticket is open for one year now.

I did update ng2-pdf-viewer to version 9.1.2, and pdfWorker to 2.14.305 and still getting same issue with {{date}} and {{time}}

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Akxe commented

Absence of activity does not mean it is not relevant. This is still the case to my knowledge...

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Still not stale