Valheim-Modding/Jotunn

[BUG]

DrewKestell opened this issue · 1 comments

DrewKestell commented

Details:
Jotunn Version: 2.4.1.0
Jotunn Submodule(if applicable):
Repeatability: Consistent(100%)

There's a bug in this code:

Jotunn/JotunnLib/Utils/AssetUtils.cs

Line 129 in a5e3dae

resourceName = resourceAssembly.GetManifestResourceNames().Single(str => str.EndsWith(bundleName));

Specifically, this line of code:
resourceName = resourceAssembly.GetManifestResourceNames().Single(str => str.EndsWith(bundleName));

I have two AssetBundles - daisy and pickable_daisy. When that code executes while trying to load daisy, Single() will throw an exception, and swallow that exception.

I would suggest doing some more intelligent string matching, probably by splitting on the . and retrieving the last segment.

Let me know if this repo is open to public contributions and I can submit a PR.

Thanks!

joeyparrish commented

I believe they are open to contributions. I've had a good experience sending PRs so far.

  • 👍1