Valiev/almostontop

Screen cleared after only pressing return

jslabovitz opened this issue · 9 comments

jslabovitz commented

In 0.5.0, the screen would clear only after actually running a command. If I just pressed return one or more times, lines would be added as they would be in a zsh without almostontop. This seemed the correct and unsurprising behavior.

In 0.6.0, pressing return clears the screen, but leaves two prompt lines on the screen. (Just press return once and you'll see -- let me know if you need a screen shot.)

It seems that the plugin should do one or the other -- either clear the screen after an empty command, leaving only one line with the current prompt, or allow multiple empty commands to stack up before clearing the screen for a real command.

Valiev commented

Hi @jslabovitz , thanks for the report. Not sure I'm getting you. Could you please send screenshot (or asciinema cast)?

rawkode commented

Yeah, something has changed here. I run this plugin along side auto-ls and now when I press enter, it's clearing the auto-ls; which wasn't normal

rawkode commented

I don't mind if it clears the screen on the "enter" key, but I'd love for auto-ls to still function with this

Valiev commented

Hi @rawkode , could please put auto-ls plugin load prior to almostontop and check again.

rawkode commented

@Valiev Apologies for the delay, I took a lot of time off for the holidays.

I've put auto-ls before almostontop, but I'm still seeing the ls aspect cleared.

##
# Always Clear Screen & Run `ls`
##
AUTO_LS_COMMANDS=(exa git-status)

zplugin ice lucid pick"auto-ls.zsh"
zplugin load "desyncr/auto-ls"

auto-ls-exa () {
  exa
  [[ $AUTO_LS_NEWLINE != false ]] && echo ""
}

zplugin ice lucid pick"almostontop.plugin.zsh"
zplugin load "Valiev/almostontop"

This is my config

Valiev commented

I do not use zplugin machinery. What I did:

  1. git clone https://github.com/desyncr/auto-ls to ~/.oh-my-zsh/custom/plugins/
  2. enabled this plugin in ~/.zshrc into plugins variable prior to almostontop
  plugins=(
    auto-ls
    almostontop
    brew
    ...
  1. PROFIT

Everything worked fine.

Valiev commented

@rawkode @jslabovitz closing due to inactivity