ValleyAudio/ValleyRackFree

Build failure on all platforms with Rack build system

Closed this issue · 9 comments

In file included from src/Terrorform/Terrorform.cpp:1:
src/Terrorform/Terrorform.hpp:33:10: fatal error: '../../dep/dr_wav.h' file not found                                                                                                                                                                                                                                
#include "../../dep/dr_wav.h"                                                                                                                                                                                                                                                                                        
         ^~~~~~~~~~~~~~~~~~~~                                                          

That file is not in the repository.

It's definitely on the repo. I've been building this on three separate systems agnostic to each other. Any suggestion to what would cause this? Other than it not being there (which it is)?

Builds fine here.

OK. Here is the problem: Rack's dep.mk is used for building dependencies. It will remove a dep directory in the source tree during that process. The Rack build system (which my system emulates), executes make dep as part of the build process, which subsequently removes the dep directory. This will be a problem with Andrew's official build system also.

I recommend putting the dep directory inside of the src directory.

Huh, I didn't run into this issue on the latest version of Ubuntu, but I'll take your advice anyway. Thanks 😁

I usually put external files and git submodules in /ext or at the directory root.

This isn't a platform issue. It is an implementation defined behavior of the Rack build system. You will run into this if you execute make dep (a no-op for you) before running make.

Ahh I see, yeah I've never encountered this before, so lesson learned.

@cschol Directory moved, try now.

All good. Thank you!