Cant get members list or add bots to lobby

[SpOOnySk]

Hello, Dont know if I am doing this right but I am trying to get list of all members that are in lobby and chceck if they are in the right team. I am getting lobby info as follows:

dota = Dota2Client(client)

@dota.on('ready')
def do_dota_stuff():
    msg = dota.create_practice_lobby("PW", None)

@channel.on('message')
def do_stuff(channel, message):
    dota.lobby.add_bot_to_practice_lobby(1, DOTA_GC_TEAM.GOOD_GUYS, DOTABotDifficulty.BOT_DIFFICULTY_PASSIVE)
    print(dota.lobby)

I get lobby info (id, mode, state ...) but no info on members (even there are players in lobby) and no bot get added into lobby when slot is empty. Any advice what am I doing wrong?

Got the newest update from github. Just downloaded this library 4 days ago.

[rossengeorgiev]

Just updated to the protos. Install from the repo, and let me know if it works. There should be new fields for members

[SpOOnySk]

Thank you so much, reinstalling package from github and not using pip install dota2 works, now I have list of members in lobby. I have one more question. When I am creating practice lobby and add options parameter it dosent work:

@dota.on('ready')
def do_dota_stuff():
    settings = {
        'game_name': 'Something Awesome - 2.0',
        "game_mode": DOTA_GameMode.DOTA_GAMEMODE_CM,
        "series_type": 2,
        "radiant_series_wins": 1,
        "dire_series_wins": 0,
        "pass_key": "PWA"
    }
    dota.create_practice_lobby(options=settings)

Lobby will be created but not with the settings above. Only way I can change the settings is by config_practise_lobby. I am just wondering if I am doing something wrong or is this a bug. Its not a problem to me to chagne setting with config_practise_lobby but I am just wondering what can be a problem here.

[rossengeorgiev]

Looking at the code it seems to be setting parameters.

dota2/dota2/features/lobby.py

Lines 66 to 125 in 2036784

	def create_practice_lobby(self, password="", options=None):
	"""
	Sends a message to the Game Coordinator requesting to create a lobby.
	:param password: password of lobby
	:type password: :class:`str`
	:param options: options to setup the lobby with
	:type options: :class:`dict`
	"""
	return self.create_tournament_lobby(password=password, options=options)
	def create_tournament_lobby(self, password="", tournament_game_id=None, tournament_id=0, options=None):
	"""
	Sends a message to the Game Coordinator requesting to create a tournament lobby.
	:param password: password of lobby
	:type password: :class:`str`
	:param tournament_game_id: tournament game id
	:type tournament_game_id: :class:`int`
	:param tournament_id: tournament id
	:type tournament_id: :class:`int`
	:param options: options to setup the lobby with
	:type options: :class:`dict`
	"""
	options = {} if options is None else options
	options["pass_key"] = password
	command = {
	"lobby_details": options,
	"pass_key": password
	}
	if tournament_game_id is not None:
	command.update({
	"tournament_game": True,
	"tournament_game_id": tournament_game_id,
	"tournament_id": tournament_id
	})
	if self.verbose_debug:
	self._LOG.debug("Sending match CMsgPracticeLobbyCreate request")
	self.send(EDOTAGCMsg.EMsgGCPracticeLobbyCreate, command)
	def config_practice_lobby(self, options):
	"""
	Change settings of the current lobby.
	:param options: options to change in the lobby
	:type options: :class:`dict`
	"""
	if self.lobby is None or self.lobby.leader_id != self.steam.steam_id:
	return
	options = {} if options is None else options
	options['lobby_id'] = self.lobby.lobby_id
	if self.verbose_debug:
	self._LOG.debug("Changing lobby options of lobby %s", self.lobby.lobby_id)
	self.send(EDOTAGCMsg.EMsgGCPracticeLobbySetDetails, options)

1. The backed behavior may have changed, need to be verified against the client
2. Do you wait for lobby update to comeback form the backend when you create the lobby? Messages are queued, when you use those methods as they only do send, so if you don't yield by doing io/idle/sleep haven't been sent yet.

A simple way to check is configuring debug logging and setting verbose_debug = True. Then calling create_practice_lobby and then doing like dota.sleep(5) and looking at the log output. Also, comparing with results from (1)

[rossengeorgiev]

Honestly, those create methods would be better if they implemented waiting for a response. Blocking that way would make them easier to use I think.

[rossengeorgiev]

Also, if you are installing with pip from the repo when you already have the package installed use pip install --upgrade --upgrade-strategy only-if-needed git+https://github.com/ValvePython/dota2

[SpOOnySk]

With dota.sleep(5) it is working right now. Thanks for your help. You can close this Issue now.