VansonLeung/react-native-jelly-side-menu

More `setState` warnings

jhen0409 opened this issue · 6 comments

It seems this line will unmount JellySideMenuSvg, so setState will not work in JellySideMenuSvg.

2016-07-10 9 18 30

Thanks, fixed

@VansonLeung I don't think it's fixed, isMounted is killed in new react version, and it's not the right place. I think we should remove all listeners in componentWillUnmount for JellySideMenuSvg.

2016-07-11 5 03 38

Fixed thanks

I am recently used this module, but got warnings on every single click on Close Side Menu & when I click on open Jelly Menu it breaks the code & the animation stop working ...

image

Thanks, will fix by tomorrow!

Thanks :)