Link position mae to endorsement instead of boolean

Question

Link position mae to endorsement instead of boolean

bjerrecs opened this issue 9 months ago · 3 comments

New bookings made by the following users ('1562956','1449414') resulted in the training tag been applied to the booking.

They get the error "training tag was forced due to booking a restricted position"
They are both in pre-training for S3 in Denmark.
They both have ATC Active & EKCH TWR on the endorsement page

I'm unable to replicate, as i have a SUP rating.

Answer 1 · 2024-03-26T19:51:38.000Z

Which positions did they attempt to book?

Answer 2 · 2024-03-26T20:35:14.000Z

EKCH_A_TWR

Answer 3 · 2024-03-26T22:20:25.000Z

I've confirmed this bug, it's a known issue that will exist until we link each position to a respective endorsement. Today we only say mae true/false, and it makes it impossible to check if the student has this endorsement in question.

The fix is changing the mae column in positions to link into an rating_id instead. Then use this to check if user has it in BookingController, if not, force the training tag.