Vectorial1024/EliteBionicsFramework

Really weird version-check bug, pretty minor. Associated w/ local copies.

Closed this issue · 3 comments

So I was getting a 'Could not detect the proper version of Cyber Fauna'. Then something red errors w.r.t. CommunityUnificationUtil. Searching the community discord and via google found me nothing. As in, zero, not even anything showing anyone had this error before. That's always a good sign.

Really should have saved a copy. This is more info & workaround for future people who might get that issue than a bug that needs to be solved.

I haven't played in about 6 months, but I'd redownloaded all the mods two days ago, figured it should be the proper, 1.4 EBF & CF versions. Kept all my local mods, just in case I needed to apply the same fixes to get my modpack integrated together again. It's a thing. You know how it is. Came in handy before, came in handy yesterday.

So. Turns out your modcheck fails if it finds a disabled, local copy of Cyber Fauna 1.3 in your local mods. And it throws a weird half error, it doesn't even give advice to get the proper version, which it should, going by your code.

Kinda wish I hadn't deleted that old version so I could easily launch again and find out. Deleting it removed the error on the next launch.

Like I said, super minor. Still kinda spooky-weird, though.

Hi there!

Some info:

  • I mostly detect mods by their Steam ID, so maybe local copy of mods might influence whether things are detected correctly (esp if they do not have Steam ID)
  • From this post, I should definitely review whether I am detecting any mods or only mods that are enabled
  • I would leave the actual mod upgrading to the users, but I roughly remember there being some mess with Cyber Fauna; something like "the original mod was un-updated, Mlies took over, and then suddenly the original mod updated"
    • There are two possible directions to fix this: either upgrade Cyber Fauna, or roll back the version of this mod

I will just decide that this issue will focus on the "detecting disabled mods" part of the post.

Fair! My biggest thought was that there was zero similar hits, and thus no solutions out there. If it even helps one person, someday, somehow, it was worth it. It's easy to not even consider that a local, disabled, old copy of a mod could affect things. We users always find a new way to break things.

To research and clarify things a bit further, both my 1.3 (local), and 1.4 (workshop) versions of C.F. had the same author and workshop number in /About/PublishedField.txt . I just spend about 15 minutes looking at old C.F. discussion comments, and if I recall correctly, my local copy of the 1.2 C.F. just had the About.xml version number incremented to 1.3, as that's exactly what the 'continued' version had done. So, yeah, super-rare edge case.

But still, I just released a super small update that adds in a check for "AnyLoadedContent"; tbh I don't even know how to test this, but apparently it should indicate whether the mod has loaded anything, which means this can be used to determine whether the mod is really loaded or not.

I'm closing this as "already done".

If anyone else have a new problem, please open a new one.