Velleman/python-linkplay

Multiroom join/unjoin does not work

heinzma opened this issue · 1 comments

I am currently testing the latest Home Assistant beta and noticed that it is not possible to join/unjoin devices.

I narrowed it down to this:

def eth(self) -> str:
"""Returns the ethernet address."""
return (
self.properties[DeviceAttribute.ETH_DHCP]
if DeviceAttribute.ETH_DHCP in self.properties
else self.properties[DeviceAttribute.ETH0]
)

Isn't DeviceAttribute.ETH_DHCP a flag for DHCP/Static IP Address?

Furthermore, with my devices (Arylic S10+, EDIFIER MS50A ) there is no DeviceAttribute.ETH0. It's DeviceAttribute.APCLI0 when connected to wifi or DeviceAttribute.ETH2 (Arylic S10+) when connected to ethernet.
When i change the return value to self.properties[DeviceAttribute.APCLI0] it works with my devices.

I'll take a look to see. Thank you for testing beta!