Multiroom: IP address still not correctly accessed
heinzma opened this issue · 1 comments
Firstly, thanks for the great work and for adressing my previous issue so fast!
Unfortunately, the changes do not fix the issue completely.
I still don't understand the purpose of this line of code.
python-linkplay/src/linkplay/bridge.py
Line 75 in 6fdf6b8
I assume it was intended to change it to if DeviceAttribute.ETH2 in self.properties but was overlooked.
More importantly, with some of my devices (Arylic S10+) there is a DeviceAttribute.ETH2(empty string) even when not connected to ethernet.
My other device (EDIFIER MS50A) has DeviceAttribute.APCLI0 and DeviceAttribute.ETH0 which is always 0.0.0.0 (no ethernet port).
I suppose there could be more variants with other devices.
Wouldn't it be better to introduce something like bridge.ip? Similar to bridge.endpoint without the http(s)://.
The eth logic will have to be improved, I guess. bridge.ip but it will need to be looked how this can work for the non-ip endpoints.