Bump the MacOS runners to use non-deprecated runners (Probably MacOS-14)
mapkon opened this issue · 8 comments
Context
Jobs are failing with this message
This is a scheduled macOS-11 brownout. The macOS-11 environment is deprecated and will be removed on June 28th, 2024.
This is because the MacOS-11 environment is deprecated. We need to bump it to the latest.
Expected Outcomes
- Bump the MacOS runners in the workflows to use the latest environment.
- The changes should be made in the
.github/workflows/go.yml - I think we should test with
MacOS-14, which if successfully should be the runner of choice moving forward
- The changes should be made in the
- Ascertain that the subsequent builds work fine
- Attempt a local release and check binary compatibility
- Ensure that the coverage reports are created properly.
References
This could be duplicating effort as according to https://github.com/actions/runner-images/tree/main?tab=readme-ov-file#available-images, macos-latest already uses macos-14
Thanks @tinaboyce
@gliptak do we still need MacOS-11? I remember some reason why we maintained?
maybe it was amd64 vs arm64? the least could be bumped to https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md at this point
maybe it was amd64 vs arm64? the least could be bumped to https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md at this point
What would be the material effect of just removing it?
I think testing both amd64 and arm64 still of value
Although for releases goreleaser covers architectures https://github.com/Versent/saml2aws/blob/master/.goreleaser.macos-latest.yml#L15-L17
Is there a reason we are testing on ubuntu-latest, macOS-latest, macos-12 and releasing on ubuntu-latest, ubuntu-20.04, macos-latest?
@charlottecampbell193 testing is based on runner while releasing on cross platform GoReleaser
if applicable, please propose realignment