VictorNine/bitwarden-go

Unable to delete items and folders with bitwarden-web v1.24.0

leonghui opened this issue · 7 comments

leonghui commented

Deleting an existing item appears to work but upon refresh, the item still exists. Same behaviour when deleting folders.

Server stdout reports:
2018/03/24 04:32:25 user@user.com is trying to edit his data
2018/03/24 04:32:25 strconv.ParseInt: parsing "67/delete": invalid syntax
...
2018/03/24 04:37:57 user@user.com is trying to update a folder
2018/03/24 04:37:57 Folder 423b3f90-46ee-448d-adb0-a9f47edcef89/delete updated

EDIT:
Other clients (tested: Android app 1.51.1, Firefox extension 1.25.4):
Item deletion works fine. Folder deletion is broken, deleted folders reappear after sync.

Server stdout for other clients:
2018/03/24 04:48:23 user@user.com is trying to edit his data
2018/03/24 04:48:23 Cipher 68 deleted
...
2018/03/24 04:50:05 user@user.com is trying to update a folder

Odysseus16 commented

I have also implemented the new API. So if you want, you can try my version (but at the moment the database is not compatible with VictorNines.
I plan to submit a pull request in the next time, but as I have done major changes it is hard to make my branch compatible with VictorNines.

leonghui commented

@Odysseus16
Thanks for your work, I am looking forward to Totp support but I will need to migrate my data over to your build for testing.

@VictorNine
Issue above still exists after 17c1ff3 (tested: Android app 1.51.2, Firefox extension 1.25.7, and bitwarden-web 1.25.1)

timreuscher commented

@Odysseus16 Does your fork support Match Detection yet? I know this one doesn’t.

VictorNine commented
timreuscher commented

@VictorNine My bad. It does work after the update. I made the change in the web vault but hadn’t synced it to my browser add-on. Appreciate the work on this.

VictorNine commented

Good to hear. I'll look in to the folders as well

davehope commented

@VictorNine, did you ever get to look at the folder deletion issue?