VideoSpike/nativescript-web-image-cache

Rounded corners not possible

Closed this issue · 7 comments

Setting border-radius via CSS does not apply here, like it does on the stock Image module (in order to create a rounded-image).

will look into it

No need, created a PR #19

@manijak
Thanks a ton! :)

I'll test it and merge it by this weekend, I hope that is okay :)

I'll also try to see if equivalent is possible in SDWebImageCache (the ios equivalent)

Merged, let this issue be open for now, I'll see if equivalent is possible for iOS

Ok, for iOS it works by using a css class and setting border-radius half the size of the image. Not sure if SDWebImage has a similar property like Fresco.

I don't think it will have a similar prop. SDWebImage is extension on normal UIImage, Objective C category to be specific. If css class works for native UIImage, it should work for SDWebImage. closing this.