Initial Staging Branch Setup
Closed this issue · 6 comments
Items to do:
- Create GitHub Actions for PR checks Issue #10
- Lint Check
- Formatting/Prettier check
- Build check
- Set the staging branch to have a required status check for the pr_check job (how-to)
- Tear down existing staging environment to best "blank slate" status
- Port over project management items to this repo
- Update GitHub documentation
- Update README
- Update PR template
- Update Issue template
- Add noindex metadata header to staging site to prevent search engine crawling
RE: GitHub Actions
- Starter Workflows/Templates - Has some great templates for GitHub workflows
- Blank CI template - Good for anything CI related.
- NodeJS CI template - Shows how to run npm commands to test installs, deploys, etc.
RE: GitHub Actions
The formatting check is done with "npm format"? If so, does this not modify files? I still need to figure out how to actually run a "check".
@ollewis A npm format typically runs and modifies code to comply with format settings (probably with prettier). You might not have the required packages in this repo so you'll need to add them. I expect eslint and prettier.
Little update on the GitHub Actions task: I'm currently working on getting an auto commit set up such that changes made by eslint and prettier are included in the PR. It's failing at the moment since I'm running the check with multiple node versions; the first one to complete succeeds and creates a commit, the other ones will fail. Should be a quick fix for me on another day.
sure, and just let me know which specific check to enable, right now I see there's 4 different ones right now
sure, and just let me know which specific check to enable, right now I see there's 4 different ones right now
@rmcilwain6 Assuming we want to check all node versions we're currently testing I think the first option is the one to enable.