[Bug]: Image at top-right and Bottom left too small on mobile
Closed this issue · 19 comments
Describe the bug
I expected the longest image height to be the least height and also look good at the same time.
To Reproduce
Steps to reproduce the behaviour:
- Go to dentclack.vercel.app
- Scroll down to About Us section
- See error
Expected behaviour
I expected the images to be bigger than 200px at least
Screenshots
Smartphone (please complete the following information):
- Device: Android
- Browser: Chrome
Additional context
Change image to an image with longer height
Can you describe a little what exact changes do you want so that I can work on this?
You want changes only in the mobile screen view?
You want changes only in the mobile screen view?
You can change across all screen size, just want the image to be long at least.
Can you describe a little what exact changes do you want so that I can work on this?
But I can't assign you to this now, I have just assign you to something else.
I am not able to remove that bug in the contributors file, so please assign this to me.
I am not able to remove that bug in the contributors file, so please assign this to me.
Okay let me unassigned you on that one first 😂.
You didn't try enough you know??? But it is fine 😁
I tried using contributors-img but it wasn't working. However I was currently working on increasing the height of the images.
Go to pexel.com and search for a doctor image, download the one with the best height and us it.
No need to spoil the image, see why communication is key 😁.
@aryanlath
Thanks for the guidance
Is this looking good to you or the image should have no padding from above and below?
Thanks for the guidance
Is this looking good to you or the image should have no padding from above and below?
The padding isn't the issues, the small images size is the issue.
The fix is just simple, change the images to a bigger one.
i think @pythoniclaver means we should make them take the entire row on mobile?
i think @pythoniclaver means we should make them take the entire row on mobile?
That's not what I mean but it is worth trying for sure 💯💯💯
Ok thanks for your inputs!
Hey @pythoniclaver !
Are you still looking for improvements on this?
If yes, I would like to work upon this.
Hey @pythoniclaver !
Are you still looking for improvements on this?
If yes, I would like to work upon this.
Yes please, the issue haven't been resolved
@zmusaddique Should I assign you to this?
Sure
Hey @pythoniclaver !
Are you still looking for improvements on this?
If yes, I would like to work upon this.Yes please, the issue haven't been resolved
@zmusaddique Should I assign you to this?
Yes sure!
This is how the changed mobile view looks 👆
Are you happy with it?
This is how the changed mobile view looks 👆 Are you happy with it?
@zmusaddique sorry for the late reply, I'm been busy with work. I'm really happy with it.
Make it a pull request, I will accept and merge. Thanks 👍🙏
@zmusaddique sorry for the late reply, I'm been busy with work. I'm really happy with it.
Make it a pull request, I will accept and merge. Thanks 👍🙏
Glad that you liked it. I've made the pull request.
Thanks @pythoniclaver for assigning ✌