remove unnecessary requirements of mutable objects in many procs

Question

remove unnecessary requirements of mutable objects in many procs

Vindaar opened this issue 7 years ago · 2 comments

Many procs still require a mutable object as their first argument, although in quite a few places that is not strictly necessary.

Needs to be cleaned up and some procs need a better separation between state changing parts and pure parts.

Answer 1 · 2018-12-19T16:11:46.000Z

One possible solution to this whole problem would be a change of objects to reference objects.

Answer 2 · 2019-11-17T17:23:59.000Z

In #32 all objects are finally made ref objects. From here only procs which internally call visit_file will require a var argument.
For that proc it's debatable, whether it's required - the H5FileObj is given as a raw pointer to the C library in addition to a Nim callback. We could probably get away with unsafeAddr here too.