SQL long time request executions with null passed as itemId to ItemServiceImpl.GetById() method
tatarincev opened this issue · 3 comments
tatarincev commented
Seems this issue already has been fixed by #227 but need to check to be ensure.
How to reproduce:
Pass null as itemId into https://github.com/VirtoCommerce/vc-module-catalog/blob/dev/VirtoCommerce.CatalogModule.Data/Services/ItemServiceImpl.cs#L45
OlegoO commented
I call service with these parameters
var product = _itemsService.GetById(model.Id, ItemResponseGroup.ItemLarge | ItemResponseGroup.ItemAssociations | ItemResponseGroup.ItemProperties);
yecli commented
Optimized service methods as there were redundant queries even with optimized repository methods.