VirtoCommerce/vc-module-order

BeforeSaveChanges not called in CustomerOrderService.SaveChanges

azapotoczny-forte opened this issue · 3 comments

Version info:

  • Browser version: not relevant
  • Platform version: 3.317.0
  • Module version: 3.245.0

CrudService calls BeforeSaveChanges method when saving changes. CustomerOrderService inherits from CurdService and changes that behavior. This violates the Liskov Substitution Principle.

OlegoO commented

@azapotoczny-forte Thank you for feedback, we will resolve it max in next two weeks (current sprint).
https://virtocommerce.atlassian.net/browse/PT-13270