Vlek/RuinsAndRiches

Serialization/Deserialization borked

Opened this issue · 4 comments

Vlek commented

After the last big push, it appears that the server saves are messed up.

I have gone through several files line by line through both serialization and deserialization to see what I could find that would give me an idea of what could have gone wrong:

  • Several creates in Plants because I think SwampTenticle showed up in the error report
  • BaseArmor
  • BaseWeapon
  • Item
  • Mobile

Instead, what I think I am going to do now is revert back half the project, so the entire System folder, and see if that fixes it. If not, I am going to revert back Scripts. That should help me narrow it down by half hopefully and then I can continue narrowing down from there.

First things first, I am going to make sure I have a good test bed by reverting the code back and ensuring that that works with a backup save.

Just for my own notes, I lost probably about 20k worth of gold and a level 6 gold golem book in my last playtime.

Vlek commented

Double-checked and it's not the exe it seems? Or maybe it too is broken?

Vlek commented

I believe this may be due to the formatting.

Going to go through and redo the past five closed tickets one by one.

Vlek commented

I also need to create a testing workflow to ensure things are working correctly:

  • Tests must build and run
  • The server should be able to be run.
  • The server shuts down gracefully.
  • The server restarts without exception.
Vlek commented

This may be made easier with the switch to modernuo, but I don't think it'll fix it if I mess up the serialization later.