Change deprecated testing imports
nikgil opened this issue · 5 comments
Should be an improvement but noticed in unit testing that junit.framework.Assert is used quite a bit. This has been deprecated for a while junit-team/junit4#473 and since this project is active should transition to non-legacy methods org.junit.Assert for better maintainability (or even JUnit 5).
Hi @SirNikolai would you like to submit a PR for this?
I think someone else started one. Was more interested in whether it would be a decent idea to move altogether to JUnit 5. Otherwise I wouldn't mind leaving it for someone else since already have a PR for something else out. That said if there are no takers can always circle back and do this over the weekend.
yes, I don't think there are any takers for this so you can totally take this on. The push is to move to JUnit 5. The other PR was centered around a Hacktoberfest issue and not particularly around removing deprecated testing imports. So if you are up for it, I will assign this issue to you.
@yallen011 sure go for it. Can get the fundamentals of it done at least.
Fixed in 6.0.0 release