Vonage/vonage-php-sdk-core

Verify v1 - Deprecations when getting Verification::getRequest()

kissifrot opened this issue · 3 comments

kissifrot commented

We are getting deprecation messages every time we call verify()

Expected Behavior

When using verify()->check($verificationCode, $code), we should not get deprecation warnings

Current Behavior

When using verify()->check($verificationCode, $code), we are getting lots of deprecation messages User Deprecated: Vonage\Verify\Verification::getRequest() is deprecated. Please get the APIResource from the appropriate client to get this information

Possible Solution

Steps to Reproduce (for bugs)

  1. Just use verify()->check($verificationCode, $code) (we use it in symfony context)

Context

Our sentries issues are filled with those messages 😅

Your Environment

  • Version used: 4.3.1
  • Environment name and version (e.g. PHP 7.2 on nginx 1.19.1): PHP 8.2 on nginx
  • Operating System and version: Ubuntu 20.04 LTS
SecondeJK commented

Thanks for reporting this.
I'll need to do a bit of investigation, as removing the deprecations (we had a circular warning dependency problem here) might be a backward breaking change, which means it'll have to wait until 5.0