Provide an iFix install process same as Open Liberty
leochr opened this issue · 3 comments
The iFixes for WL are added to /opt/ibm/fixes while Open Liberty uses /opt/ol/fixe. This means the application Dockerfile would have to be changed when switching between OL and WL.
Evaluate and implement a way to provide the same iFix install process. One option to consider is keeping the current paths, but adding a symlink. If this works, update the sample Dockerfile in readme.
Upon finding a correct symlink for the ifixes, I discovered there is a long existing typo between WL and OL that made it's way into the code base at different times:
WASDev/ci.docker updated ln -s /opt/ibm /liberty
OpenLiberty/ci.docker updated ln -s /opt/ol/wlp /liberty
I am under the impression that /opt/ol/wlp and /opt/ibm/wlp are the correct symlinks for /liberty as the initial symlink was added to make it easier to copy in the usr folders. This is because the /opt/ibm folder contains other non liberty specific folders.
/opt/ibm/helpersis our own build files (i.e. configure.sh and features.sh) only used in the container build process by ourselves./opt/ibm/javathe java install/opt/ibm/fixesfinding an appropriate symlink is harder (i.e. /liberty/fixes would map to /opt/ibm/fixes in WL but /opt/ol/wlp/fixes in OL).
In addition to the fix that can be made above, I will add a new symlink to ln -s /opt/ol/fixes /fixes and ln -s /opt/ibm/fixes /fixes and update the applying-ifixes/README.md instructions to sync on both OL and WL.
The /liberty symlink issue can be decoupled from the /fixes symlink PR and deferred to another date. Let's use #474 to track /liberty symlink update for a future date and add to the Epic.
Delivered. Closing