WC-Local-Pickup/woocommerce-local-pickup-time

Pickup time is not shown in emails that are sent when a note is added to an order

Closed this issue · 6 comments

Describe the bug
When a customer note is added to an order, the email that is sent should contain the pickup time that was selected. The email currently displays the pickup time as "None".

To Reproduce
Steps to reproduce the behavior:

  1. Create a new order for local pickup.
  2. Check the email that is sent to the customer, it should contain a pickup time.
  3. Add a customer order note which triggers an email being sent to the customer.
  4. Check the new email that contains the note, the text for "Pickup Time:" should be "None".

Screenshots
First email, containing pickup time:
image

Second email sent with note, no pickup time:
image

Expected behavior
A clear and concise description of what you expected to happen.

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce and this plugin are active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.

WordPress Environment

  • PHP Version: 7.3
  • WordPress Version: 5.4.2
  • WooCommerce Version: 4.2.0
  • Plugin Version: 1.3.12

can I work on this issue?

@dennisgon yes, for sure you are welcome to fork and submit a PR for this.

Hi I think this is because of other plugins
I already try for myself and there is no problem
image

@bendison can you confirm if you have any additional plugins that modify the WooCommerce emails?

@dennisgon thanks for your verification and analysis on this!

Closing this as in my own recent testing customer notes as well as all other order emails appear to have the pickup time as expected.